feat: add storybook preview to pr links #5065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbwoolf
force-pushed
the
feat/storybook-pr-link
branch
2 times, most recently
from
0342c2c to
7cc8929
Compare
kyranjamie
requested changes
Mar 13, 2024
There was a problem hiding this comment.
Great work @fbwoolf—this will be super helpful.
Requesting changes only on grounds that it'd be a better Github action set up to have a separate step to do the deploy, rather than bundling in with the set download link job. Consider if the job fails, then we're more easily able to see which specific step failed.
Can we also delete the notify-release.yml job as well this isn't needed anymore.
fbwoolf
force-pushed
the
feat/storybook-pr-link
branch
6 times, most recently
from
5e27236 to
26ab8a2
Compare
fbwoolf
force-pushed
the
feat/storybook-pr-link
branch
from
26ab8a2 to
e164765
Compare
|
@kyranjamie hope this is ready now? |
kyranjamie
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add published Storybook preview link to top of pull requests.