refactor: make ordinals com as main source of data for double checking utxos #4968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alter-eggo
force-pushed
the
feat/ordinals-com
branch
from
6a0ca52 to
7a9fb27
Compare
kyranjamie
approved these changes
Feb 22, 2024
|
The title of this PR indicates ordinals.com but the code seems related to BestInSlot? |
|
@markmhendrickson it might seem so, as I refactored it a bit, but the main sense of this pr is changing places between ordinals.com and bestinslot. the first one is the main source for us now, latter is fallback |
alter-eggo
force-pushed
the
feat/ordinals-com
branch
from
7a9fb27 to
a27e281
Compare
alter-eggo
force-pushed
the
feat/ordinals-com
branch
from
a27e281 to
78f519d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do extra request to get relevant inscriptions data from bestinslot, so this pr makes bestinslot api as fallback and ordinals.com as main source for double checking utxos
Issue: #4920
Discussion: https://trustmachines.slack.com/archives/C05LAP952E7/p1708420452990369