Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add check inscription send utxos #4947

Merged
merged 1 commit into from
Feb 16, 2024
Merged

feat: add check inscription send utxos #4947

merged 1 commit into from
Feb 16, 2024

Conversation

alter-eggo
Copy link
Contributor

@alter-eggo alter-eggo commented Feb 15, 2024 •
edited by github-actions bot
Loading

Try out this version of Leather — Extension build, Test report

Add utxos double checking in the inscription send flow

kyranjamie
kyranjamie approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though wonder if this filtering logic should not just be in the inscription review screen?

src/app/pages/send/ordinal-inscription/send-inscription-review.tsx Outdated Show resolved Hide resolved
@alter-eggo alter-eggo force-pushed the feat/prevent-inscription-send branch from dd8f2fb to ae73aaa Compare February 15, 2024 13:45
@alter-eggo alter-eggo merged commit 301b6d4 into feat/block-btc-tx Feb 16, 2024
19 checks passed
@alter-eggo alter-eggo deleted the feat/prevent-inscription-send branch February 16, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alter-eggo @kyranjamie