feat: implement double checking for spendable utxos #4893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alter-eggo
changed the title
alter-eggo
force-pushed
the
feat/block-btc-tx
branch
3 times, most recently
from
dee9b84 to
93f65d9
Compare
kyranjamie
reviewed
Feb 5, 2024
src/app/query/bitcoin/transaction/use-bitcoin-broadcast-transaction.ts
Outdated
Show resolved
Hide resolved
kyranjamie
reviewed
Feb 5, 2024
src/app/pages/send/send-crypto-asset-form/form/btc/btc-send-form-confirmation.tsx
Outdated
Show resolved
Hide resolved
kyranjamie
reviewed
Feb 5, 2024
src/app/query/bitcoin/transaction/use-bitcoin-broadcast-transaction.ts
Outdated
Show resolved
Hide resolved
kyranjamie
reviewed
Feb 5, 2024
alter-eggo
force-pushed
the
feat/block-btc-tx
branch
3 times, most recently
from
9f37da3 to
614e81e
Compare
kyranjamie
reviewed
Feb 14, 2024
Comment on lines
85
to
82
| await refetchOrdInscriptionsList(); | ||
| const ordinalsComResponses = await Promise.all( |
There was a problem hiding this comment.
Don't we want to use allSettled here? What if one fails?
There was a problem hiding this comment.
do we really need to wait till all settled? I believe if one request fails - we can process error immediately
alter-eggo
force-pushed
the
feat/block-btc-tx
branch
3 times, most recently
from
3a85a2c to
49fe18f
Compare
alter-eggo
force-pushed
the
feat/block-btc-tx
branch
2 times, most recently
from
9d0e937 to
d6847cb
Compare
fbwoolf
reviewed
Feb 22, 2024
fbwoolf
reviewed
Feb 22, 2024
alter-eggo
force-pushed
the
feat/block-btc-tx
branch
from
d5dd0e6 to
1a64289
Compare
kyranjamie
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the BTC send flow we filter spendable utxo using Hiro API, in order to double check spendable utxos on the last step of tx flow we fetch inscriptions by utxo id using bestinslot api