chore: improve display of lock screen, closes #4606 #4716
Merged
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete-watters
force-pushed
the
fix/4606/password-alignment
branch
from
237fa51 to
c53f56c
Compare
fbwoolf
reviewed
Dec 18, 2023
| @@ -26,7 +26,9 @@ export function TwoColumnLayout({ | |||
| gap="space.07" | |||
| mx={['auto', 'space.03', 'space.03', 'space.03']} | |||
| > | |||
| <styled.div maxWidth="440px">{leftColumn}</styled.div> | |||
| <styled.div minWidth="440px" maxWidth="440px" textAlign="left"> | |||
There was a problem hiding this comment.
Would setting the min and max width here as the same be just a fixed width of 440px? 🤔
There was a problem hiding this comment.
Thanks @fbwoolf 🤦 the worst part is I saw this but thought I was avoiding a set width. I'll update it
fbwoolf
approved these changes
Dec 18, 2023
kyranjamie
approved these changes
Dec 18, 2023
pete-watters
force-pushed
the
fix/4606/password-alignment
branch
from
c53f56c to
e520cea
Compare
pete-watters
force-pushed
the
fix/4606/password-alignment
branch
from
e520cea to
ea7cdbe
Compare
|
Mmm, forgot some of the lock screen issues will've been fixed here |
Did you want to release this? I can do another release. This is just some minor visual tweaks |
|
It's been released already so why not! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some improvements to the UI of:
Kapture.2023-12-18.at.12.28.48.mp4