Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set up sandbox page #4443

Closed
wants to merge 1 commit into from
Closed

feat: set up sandbox page #4443

wants to merge 1 commit into from

Conversation

alter-eggo
Copy link
Contributor

@alter-eggo alter-eggo commented Oct 26, 2023

Try out this version of Leather — download extension builds.

Adds sandbox page with app's components

@@ -166,6 +167,15 @@ export function SettingsDropdown() {
Lock
</MenuItem>
)}
{!IS_PROD_ENV && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can avoid this and just get people that need it to bookmark the URL?

Just as I don't think we should mix sandbox stuff with real production code

Copy link
Contributor Author

@alter-eggo alter-eggo Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just for convenience. I believe there is no problem in adding menu item there

@@ -0,0 +1,16 @@
import { Flex, Stack, styled } from 'leather-styles/jsx';

const textVariants = ['label.01', 'label.02', 'label.03', 'heading.01', 'heading.02', 'heading.03'];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can pull programatically from theme directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, done

@alter-eggo alter-eggo marked this pull request as ready for review November 1, 2023 01:40
@alter-eggo alter-eggo self-assigned this Nov 1, 2023
@alter-eggo
Copy link
Contributor Author

close in favor of storybook

@alter-eggo alter-eggo closed this Nov 2, 2023
@pete-watters pete-watters deleted the feat/sandbox branch February 14, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants