fix: tx req fee error #4430
Merged
fix: tx req fee error #4430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbwoolf
force-pushed
the
fix/tx-request-fee-error
branch
from
759316e to
fe04d65
Compare
| @@ -111,6 +103,15 @@ export function StacksTransactionSigner({ | |||
| > | |||
| {() => ( | |||
| <> | |||
| <PageTop /> | |||
There was a problem hiding this comment.
Maybe we can extract these components into another file so we can include that in stacks-transaction-signer.tsx and transaction-request.tsx instead of repeating these lines
There was a problem hiding this comment.
Yeah, we need to refactor our transaction flows for sure, agree lots of duplicate code. I created a code health issue for it here: #3594
pete-watters
approved these changes
Oct 26, 2023
kyranjamie
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now shows error if the fee is set higher than available STX... the fee form needed to wrap the error components so it was available to use. I'm not sure why
transaction.feewas used originally, but our form handles the fee. And, the conversion here was wrong bc the amount is in microstacks.