chore: take out Stacks UI theme provider #4179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete-watters
force-pushed
the
chore/stacks-ui-removal
branch
from
c6a6a29 to
1c78864
Compare
pete-watters
force-pushed
the
chore/emotionless
branch
4 times, most recently
from
55c7d17 to
1d2e578
Compare
pete-watters
force-pushed
the
chore/stacks-ui-removal
branch
from
1c78864 to
18a8c0b
Compare
pete-watters
force-pushed
the
chore/emotionless
branch
from
1d2e578 to
902ec9a
Compare
pete-watters
force-pushed
the
chore/stacks-ui-removal
branch
from
3d35259 to
78c9238
Compare
pete-watters
force-pushed
the
chore/stacks-ui-removal
branch
3 times, most recently
from
ff748a0 to
84f0a9c
Compare
pete-watters
force-pushed
the
chore/stacks-ui-removal
branch
from
84f0a9c to
2d2d8bb
Compare
|
Closing off for now, can revisit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes out the Stacks UI
<ThemeProvider+theme, ripping off the plaster and highlighting some areas we have been relying on it.It causes a lot of knock on effects in the UI missing styles:
https://github.com/leather-wallet/extension/assets/2938440/62cb8daa-09a9-4dd9-9af4-239fe5d374f8
Rather than port the old theme and styles I believe it best to continue down this path and rip out everything, then fix what we have leftover