Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename leaf to leather #4160

Merged
merged 1 commit into from
Sep 3, 2023
Merged

refactor: rename leaf to leather #4160

merged 1 commit into from
Sep 3, 2023

Conversation

alter-eggo
Copy link
Contributor

See title

kyranjamie
kyranjamie approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

On name, would it be nice to name leather-ui or something?

@alter-eggo
Copy link
Contributor Author

alter-eggo commented Sep 1, 2023 •
edited
Loading

@kyranjamie leather-styles to leather-ui-styles? doesn't styles implies ui?

@kyranjamie
Copy link
Collaborator

It does, I just wonder if leather-ui is a better name

@alter-eggo
Copy link
Contributor Author

seems styles is better 😁
Screenshot 2023-09-01 at 12 06 21

@alter-eggo alter-eggo force-pushed the refactor/layout-radix branch 2 times, most recently from 043facd to 19c43cd Compare September 3, 2023 16:27
Base automatically changed from refactor/layout-radix to dev September 3, 2023 16:36
@alter-eggo alter-eggo force-pushed the refactor/rename-leaf branch 2 times, most recently from 228a535 to 92a711a Compare September 3, 2023 16:58
@alter-eggo alter-eggo added this pull request to the merge queue Sep 3, 2023
Merged via the queue into dev with commit 66d159e Sep 3, 2023
31 checks passed
@alter-eggo alter-eggo deleted the refactor/rename-leaf branch September 3, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alter-eggo @kyranjamie