fix: check broadcast param as string #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
approved these changes
Aug 31, 2023
pete-watters
approved these changes
Aug 31, 2023
fbwoolf
force-pushed
the
fix/psbt-broadcast-param-check
branch
from
4f9ba97 to
4b7a0f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the ME bug with the popup not closing. They are sending the new
broadcastparam asfalse, but my check was for it being present not as the stringtrue. When callingtx.finalize()it errored (which makes sense bc we weren't supposed to call it for ME) > didn't close popup > they proceeded to broadcast the tx on their own. I added a try/catch here around finalizing the tx too so that it will route to the error page correctly.Also, there have been reports of our docs saying the network defaults to the current network, but I noticed here when the rpc method was added, we default to
mainnet...so I removed that too.Fixed a minor UI bug in the
GenericErrorcomponent ...and fixed a console error with anh1tag.