Fix configuration of theme while locked

[markmhendrickson]

Screen.Recording.2024-01-18.at.16.15.53.mov

[pete-watters]

This is the same issue as #4783 .

I can look into it if you want?

[pete-watters]

@kyranjamie - what are your thoughts on making the Settings Menu dialogs not routable?

• change theme
• change network
• sign out

I believe this will simplify things and help fix this bug and #4783.

We can fire an analytics page view inside of the dialogs.

The account selector is using an un-routed dialog now.

[kyranjamie]

Agree. Think we should do this, and remove the /* background routing code.

Think we should still route modals when we can, but not for global ones.

[pete-watters]

OK. I can fix the settings ones now in #4370 which will solve this bug.

Then we can attempt to move the /* routing seperately

[pete-watters]

I'll just fix this as part of #4370.

It's very similar to #4783 and relates to problems with our routing from the settings menu.

I needed to rework the settings menu anyway to use the new DropDown component. It's not much more effort to implement #4313 , at least partially.

In the new design, I can make use of the radix dropdown sub-menu to replace the modals for Theme and Change network

Then I will just have to implement a fix to the modal for Sign Out

[pete-watters]

I added this new menu:

• I used the existing menu items we already have
• I need to add the new icons

Using the new radix dropdown and the submenus aren't working too well. I've decided that for now I will keep using modals for sub-menu items but not have them routable.

That way we can still fix this issue and #4783 but we don't need to also tackle issues with the submenu.