Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routing issue: clicking sign out shows the your password page #4783

Closed
Tracked by #4655
314159265359879 opened this issue Jan 8, 2024 · 5 comments · Fixed by #4655
Closed
Tracked by #4655

Routing issue: clicking sign out shows the your password page #4783

314159265359879 opened this issue Jan 8, 2024 · 5 comments · Fixed by #4655
Assignees
@pete-watters
Labels
bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds
Milestone
Fix urgent bugs

Comments

@314159265359879
Copy link
Contributor

I was able to sign out previously without issue on version 6.21.2
I have seen one other user report the same issue but couldn't reproduce it then. Also wasn't reproducible after I unlocked the wallet and locked it again. The user who experienced this was unable to unlock their wallet and decided to reset it instead.

2024-01-08_22-58-06.mp4
@314159265359879 314159265359879 added bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds labels Jan 8, 2024
@pete-watters pete-watters self-assigned this Jan 11, 2024
@pete-watters pete-watters added bug-p2 Critical functionality broken for few users, with no clear workarounds and removed bug-p3 Non-critical functionality broken for many users, or there are clear workarounds labels Jan 11, 2024
@markmhendrickson
Copy link
Collaborator

Also seeing it

Screen.Recording.2023-12-18.at.18.50.54.mov

@markmhendrickson markmhendrickson added this to the Fix urgent bugs milestone Jan 23, 2024
@314159265359879
Copy link
Contributor Author

This is unresolved in version 6.24.0

@pete-watters pete-watters removed their assignment Jan 25, 2024
@pete-watters
Copy link
Contributor

This isn't fixed yet as I have been busy trying to finish #4370 . I'll un-assign myself for now and get to it as soon as I can

@pete-watters pete-watters mentioned this issue Feb 6, 2024
Closed
@pete-watters pete-watters self-assigned this Feb 7, 2024
@pete-watters
Copy link
Contributor

I'll just fix this as part of #4370.

It's very similar to #4826 and relates to problems with our routing from the settings menu.

@pete-watters pete-watters mentioned this issue Feb 13, 2024
Merged
21 tasks
@pete-watters pete-watters linked a pull request Feb 13, 2024 that will close this issue
Full page extension views, containers, shared headers + footers #4655
Merged
21 tasks
@314159265359879
Copy link
Contributor Author

I tested this with the #4655 PR and I see it fixed. Users can sign out when the wallet is locked again once that is released.

@pete-watters pete-watters mentioned this issue Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds
Projects
None yet
Milestone
Fix urgent bugs
Development

Successfully merging a pull request may close this issue.

Full page extension views, containers, shared headers + footers leather-io/extension
3 participants
@markmhendrickson @pete-watters @314159265359879