-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design System: dropdown-menu #4312
Comments
@fbwoolf you mentioned that the button with token was something you were or had already tackled, correct? |
I do have a version of this built in my current swaps PR. |
@fbwoolf @kyranjamie how do we want to go about components that are build in between features? Should we separate them like we are doing with the selector? |
Yeah, I think it is a good idea to separate, or at least make sure the code is put into a shared location while the feature is being developed. Typically, I would say best to tackled separately, but in this case it might be best for me to just separate the code in my PR since it is part of refactoring existing work not yet merged? |
@fbwoolf Ticket for dropdown has been updated. Let me know if this works |
@fbwoolf - just a heads up that for the work on the new headers, I need to restrict the width of the The current menu we have positions itself absolutely so this means on wide screens it goes far away from the trigger button: I'm hopeful that the Radix dropdown will work better out of the box but thought I best let you know in case. You will be able to check easily enough by adding a max-width of |
## [6.22.0](v6.21.2...v6.22.0) (2024-01-09) ### Features * add storybook, ref [#1230](#1230) ([958f177](958f177)) * deploy storybook with chromatic ([b22ee5d](b22ee5d)) * ui dropdown and select, ref [#4312](#4312) and [#4417](#4417) ([3bd7ab4](3bd7ab4)) ### Bug Fixes * asset list ui bug, ref [#4603](#4603) ([9a2e8b4](9a2e8b4)) * delete unused import ([072cbd6](072cbd6)) * fee value calc bug, ref [#4742](#4742) ([a59e0d2](a59e0d2)) * infinite loader on buy screen if stacks account is not present ([1fb92aa](1fb92aa)) * nan total amount bug ([8c37393](8c37393)) * swap broadcasts, ref [#4750](#4750) ([54705e7](54705e7)) * swaps UI bug ([d4c99d5](d4c99d5)) * user should be able to buy stacks for stacks account ([b2854c0](b2854c0)) ### Internal * move hooks to hooks folder ([336e12c](336e12c)) * post-release merge back ([44ca1fd](44ca1fd)) * update axios, radix, panda. remove unused radix primitives ([51320f9](51320f9)) * use isDefined function in filter ([ca7b44c](ca7b44c))
This ticket is about building the radix component dropdown-menu
Designs: https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/%E2%9D%96-Leather-%E2%80%93-Design-System?type=design&node-id=9344-35933&mode=design&t=hjqmbIyJGAvKngKO-4
More resources
https://www.notion.so/trustmachines/Design-system-components-9e2d9e70b1a14e36bd9ed7c08515a5c1
The text was updated successfully, but these errors were encountered: