Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design System: dropdown-menu #4312

Closed
mica000 opened this issue Oct 3, 2023 · 6 comments · Fixed by #4765
Closed

Design System: dropdown-menu #4312

mica000 opened this issue Oct 3, 2023 · 6 comments · Fixed by #4765
Assignees
Labels
area:components area:ui UI engineering specific tasks.

Comments

@mica000
Copy link

mica000 commented Oct 3, 2023

@mica000
Copy link
Author

mica000 commented Oct 3, 2023

@fbwoolf you mentioned that the button with token was something you were or had already tackled, correct?

@mica000 mica000 added the area:ui UI engineering specific tasks. label Oct 3, 2023
@fbwoolf
Copy link
Contributor

fbwoolf commented Oct 3, 2023

@fbwoolf you mentioned that the button with token was something you were or had already tackled, correct?

I do have a version of this built in my current swaps PR.

@mica000
Copy link
Author

mica000 commented Oct 3, 2023

@fbwoolf @kyranjamie how do we want to go about components that are build in between features? Should we separate them like we are doing with the selector?

@fbwoolf
Copy link
Contributor

fbwoolf commented Oct 3, 2023

@fbwoolf @kyranjamie how do we want to go about components that are build in between features? Should we separate them like we are doing with the selector?

Yeah, I think it is a good idea to separate, or at least make sure the code is put into a shared location while the feature is being developed. Typically, I would say best to tackled separately, but in this case it might be best for me to just separate the code in my PR since it is part of refactoring existing work not yet merged?

@mica000 mica000 changed the title Design System - Input selector and Token button Design System - dropdown-menu Oct 24, 2023
@mica000
Copy link
Author

mica000 commented Oct 24, 2023

@fbwoolf Ticket for dropdown has been updated. Let me know if this works

@mica000 mica000 changed the title Design System - dropdown-menu Design System instace - dropdown-menu Oct 24, 2023
@mica000 mica000 changed the title Design System instace - dropdown-menu Design System Instance: - dropdown-menu Oct 24, 2023
@mica000 mica000 changed the title Design System Instance: - dropdown-menu Design System Instance: dropdown-menu Oct 24, 2023
@fbwoolf fbwoolf self-assigned this Dec 20, 2023
@pete-watters
Copy link
Contributor

@fbwoolf - just a heads up that for the work on the new headers, I need to restrict the width of the HomeHeader to 882px.

The current menu we have positions itself absolutely so this means on wide screens it goes far away from the trigger button:
Screenshot 2023-12-22 at 11 19 24

I'm hopeful that the Radix dropdown will work better out of the box but thought I best let you know in case. You will be able to check easily enough by adding a max-width of 882px to the headers.tsx base Flex
Screenshot 2023-12-22 at 11 22 10

@markmhendrickson markmhendrickson added this to the Establish UI library milestone Jan 2, 2024
@fbwoolf fbwoolf linked a pull request Jan 2, 2024 that will close this issue
@mica000 mica000 changed the title Design System Instance: dropdown-menu Design System: dropdown-menu Jan 8, 2024
kyranjamie pushed a commit that referenced this issue Jan 9, 2024
## [6.22.0](v6.21.2...v6.22.0) (2024-01-09)

### Features

* add storybook, ref [#1230](#1230) ([958f177](958f177))
* deploy storybook with chromatic ([b22ee5d](b22ee5d))
* ui dropdown and select, ref [#4312](#4312) and [#4417](#4417) ([3bd7ab4](3bd7ab4))

### Bug Fixes

* asset list ui bug, ref [#4603](#4603) ([9a2e8b4](9a2e8b4))
* delete unused import ([072cbd6](072cbd6))
* fee value calc bug, ref [#4742](#4742) ([a59e0d2](a59e0d2))
* infinite loader on buy screen if stacks account is not present ([1fb92aa](1fb92aa))
* nan total amount bug ([8c37393](8c37393))
* swap broadcasts, ref [#4750](#4750) ([54705e7](54705e7))
* swaps UI bug ([d4c99d5](d4c99d5))
* user should be able to buy stacks for stacks account ([b2854c0](b2854c0))

### Internal

* move hooks to hooks folder ([336e12c](336e12c))
* post-release merge back ([44ca1fd](44ca1fd))
* update axios, radix, panda. remove unused radix primitives ([51320f9](51320f9))
* use isDefined function in filter ([ca7b44c](ca7b44c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:components area:ui UI engineering specific tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants