Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design System: select #4417

Closed
mica000 opened this issue Oct 24, 2023 · 2 comments · Fixed by #4765
Closed

Design System: select #4417

mica000 opened this issue Oct 24, 2023 · 2 comments · Fixed by #4765
Assignees
@fbwoolf
Labels
area:components area:ui UI engineering specific tasks.
Milestone
Establish UI library

Comments

@mica000
Copy link

mica000 commented Oct 24, 2023 •
edited
Loading

This ticket is about building the radix component select

image
https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/%E2%9D%96-Leather-%E2%80%93-Design-System?type=design&node-id=9369-13353&mode=design&t=hjqmbIyJGAvKngKO-4

ps: Design specs for this one are similar to the dropdown. Both are triggered by a button, however the selector displays a list of options for the user to pick from.

More resources
https://www.notion.so/trustmachines/Design-system-components-9e2d9e70b1a14e36bd9ed7c08515a5c1
@mica000 mica000 changed the title Design System Instance: selector Design System Instance: select Oct 24, 2023
@mica000
Copy link
Author

mica000 commented Oct 24, 2023

@fbwoolf could you also review this one?

@mica000 mica000 added the area:ui UI engineering specific tasks. label Dec 6, 2023
@fbwoolf
Copy link
Contributor

fbwoolf commented Dec 20, 2023

This issue is dependent on work from: #4312

@fbwoolf fbwoolf self-assigned this Dec 20, 2023
@markmhendrickson markmhendrickson added this to the Establish UI library milestone Jan 2, 2024
@fbwoolf fbwoolf linked a pull request Jan 2, 2024 that will close this issue
feat: ui dropdown and select, ref #4312 and #4417 #4765
Merged
fbwoolf added a commit that referenced this issue Jan 3, 2024
@fbwoolf
feat: ui dropdown and select, closes #4417 and #4312
aeb6b6a
fbwoolf added a commit that referenced this issue Jan 3, 2024
@fbwoolf
feat: ui dropdown and select, closes #4312 and #4417
9e7a70a
fbwoolf added a commit that referenced this issue Jan 3, 2024
@fbwoolf
feat: ui dropdown and select, ref #4312 and #4417
d16eb6d
@mica000 mica000 changed the title Design System Instance: select Design System: select Jan 8, 2024
fbwoolf added a commit that referenced this issue Jan 9, 2024
@fbwoolf
feat: ui dropdown and select, ref #4312 and #4417
c7a0681
fbwoolf added a commit that referenced this issue Jan 9, 2024
@fbwoolf
feat: ui dropdown and select, ref #4312 and #4417
e985e0b
fbwoolf added a commit that referenced this issue Jan 9, 2024
@fbwoolf
feat: ui dropdown and select, ref #4312 and #4417
70a09b2
fbwoolf added a commit that referenced this issue Jan 9, 2024
@fbwoolf
feat: ui dropdown and select, ref #4312 and #4417
0687d5f
github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2024
@fbwoolf
feat: ui dropdown and select, ref #4312 and #4417
3bd7ab4
fbwoolf added a commit that referenced this issue Jan 9, 2024
@fbwoolf
feat: ui dropdown and select, ref #4312 and #4417
fee2d56
@fbwoolf fbwoolf mentioned this issue Jan 9, 2024
Merged
kyranjamie pushed a commit that referenced this issue Jan 9, 2024
@semantic-release-bot
chore(release): 6.22.0
7209f64 
## [6.22.0](v6.21.2...v6.22.0) (2024-01-09)

### Features

* add storybook, ref [#1230](#1230) ([958f177](958f177))
* deploy storybook with chromatic ([b22ee5d](b22ee5d))
* ui dropdown and select, ref [#4312](#4312) and [#4417](#4417) ([3bd7ab4](3bd7ab4))

### Bug Fixes

* asset list ui bug, ref [#4603](#4603) ([9a2e8b4](9a2e8b4))
* delete unused import ([072cbd6](072cbd6))
* fee value calc bug, ref [#4742](#4742) ([a59e0d2](a59e0d2))
* infinite loader on buy screen if stacks account is not present ([1fb92aa](1fb92aa))
* nan total amount bug ([8c37393](8c37393))
* swap broadcasts, ref [#4750](#4750) ([54705e7](54705e7))
* swaps UI bug ([d4c99d5](d4c99d5))
* user should be able to buy stacks for stacks account ([b2854c0](b2854c0))

### Internal

* move hooks to hooks folder ([336e12c](336e12c))
* post-release merge back ([44ca1fd](44ca1fd))
* update axios, radix, panda. remove unused radix primitives ([51320f9](51320f9))
* use isDefined function in filter ([ca7b44c](ca7b44c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbwoolf fbwoolf

Labels
area:components area:ui UI engineering specific tasks.
Projects
None yet
Milestone
Establish UI library
Development

Successfully merging a pull request may close this issue.

feat: ui dropdown and select, ref #4312 and #4417 leather-io/extension
3 participants
@markmhendrickson @fbwoolf @mica000