Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-2023-03-30 #1175

Merged
merged 25 commits into from
Apr 12, 2023
Merged

release-2023-03-30 #1175

merged 25 commits into from
Apr 12, 2023

Conversation

edu-stx
Copy link
Contributor

@edu-stx edu-stx commented Mar 30, 2023 •
edited by github-actions bot
Loading

edu-stx and others added 12 commits January 10, 2023 13:28
@edu-stx
fix: typo
a280c13
@edu-stx
feat: update supported btc address formats
0a8fd55
@edu-stx
fix: update ci
671f3c2
@semantic-release-bot
chore(release): 4.8.0-dev.1
83bb80e 
# [4.8.0-dev.1](v4.7.0...v4.8.0-dev.1) (2023-01-10)

### Bug Fixes

* add missing space ([89345e9](89345e9))
* apple-compatible electron-builder version ([117ba23](117ba23))
* initialize sentry after loading store and checking for diagnosticPermission ([e6e7396](e6e7396))
* misc type issues and quirks ([e8544e1](e8544e1))
* remove sentry from main process ([8d50414](8d50414))
* **send-form:** incorrect fee calc in send max button ([7188bd8](7188bd8))
* types ([2351308](2351308))
* typo ([a280c13](a280c13))
* update ci ([671f3c2](671f3c2))
* webpack cli ([0afd6d2](0afd6d2))
* webpack serve ([3dbce0a](3dbce0a))

### Features

* add segment integration ([5382781](5382781)), closes [#928](#928)
* update supported btc address formats ([0a8fd55](0a8fd55))
@friedger @edu-stx
fix: accept contract addresses as pool address (#1165)
67dcdf1
@friedger @edu-stx
fix(sandbox): prettier
095bae9
@edu-stx
fix: ci gpg key import
6948d92
@semantic-release-bot
chore(release): 4.8.0-dev.2
dcbba97 
# [4.8.0-dev.2](v4.8.0-dev.1...v4.8.0-dev.2) (2023-03-29)

### Bug Fixes

* accept contract addresses as pool address ([#1165](#1165)) ([67dcdf1](67dcdf1))
* ci gpg key import ([6948d92](6948d92))
* **sandbox:** prettier ([095bae9](095bae9))
@edu-stx
docs: update quickstart
085f4fb
@edu-stx
refactor: default to mainnet
f7f309f
@edu-stx
feat: remove outdated messages
c613724
@semantic-release-bot
chore(release): 4.8.0-dev.3
06c7661 
# [4.8.0-dev.3](v4.8.0-dev.2...v4.8.0-dev.3) (2023-03-30)

### Features

* remove outdated messages ([c613724](c613724))
@markmhendrickson
Copy link
Collaborator

@edu-stx mind linking the relevant issues here on the right and moving them to the review column?

Screenshot 2023-03-30 at 13 46 01

@edu-stx edu-stx linked an issue Mar 30, 2023 that may be closed by this pull request
Remove cooldown copy from desktop wallet #1172
Closed
@edu-stx
Copy link
Contributor Author

edu-stx commented Mar 30, 2023

Only able to link the open issue #1172, the others are closed:

Fixes #1165

We also previously discussed handling #1164 in this release, although from the latest comments it still seems like it's due to issues with Stacks nodes. I'm not sure what a fix would look like?

@edu-stx edu-stx requested a review from kyranjamie March 30, 2023 12:37
@markmhendrickson
Copy link
Collaborator

Yea I'm not sure about #1164 but maybe @314159265359879 has insight into whether we can tackle it wallet-side

@314159265359879
Copy link

If a wallet has 1000.58928 STX and 1000 STX was stacking.

Sending anything over .51 STX will pend forever. But if they send the STX that were never locked they can work around it.
They can send a small amount 0.000001 STX to any address (burn address for example) and that will resolve the "lock".

In the three cased I handles yesterday the desktop-wallet-user had already send a transaction, they would have to replace the transaction so it gets processed first (first nonce that can be processed and a fee that is higher then that of the transaction already pending with that nonce, 0.072001 STX).

A more general option to (request to) delete/cancel a transaction would be helpful as proposed here: leather-io/extension#3406

Perhaps a tall order for the desktop wallet?

friedger
friedger approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@friedger friedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

friedger
friedger requested changes Apr 1, 2023
View reviewed changes
Copy link
Contributor

@friedger friedger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stacks dependencies (in particular @stacks/stacking) need to be updated to 6.5+
Otherwise #1165 still fails

@markmhendrickson markmhendrickson linked an issue Apr 3, 2023 that may be closed by this pull request
Upgrade @stacks/stacking to 6.5.0 #1182
Closed
edu-stx and others added 4 commits April 3, 2023 06:40
@edu-stx @kyranjamie
fix: zero locked balance
528b5bc
@edu-stx @kyranjamie
chore: ignore existing linting errors
3e9517b 
After upgrading eslint, many errors related to use of `any` are being
reported.
They have all been ignored due to the codebase being closer to
legacy than actively maintained at this point.
@edu-stx @kyranjamie
feat: make our lives easier
43fa4bd
@semantic-release-bot
chore(release): 4.9.0-dev.1
5d44f91 
# [4.9.0-dev.1](v4.8.0...v4.9.0-dev.1) (2023-04-03)

### Bug Fixes

* accept contract addresses as pool address ([#1165](#1165)) ([67dcdf1](67dcdf1))
* ci gpg key import ([6948d92](6948d92))
* **sandbox:** prettier ([095bae9](095bae9))
* typo ([a280c13](a280c13))
* update ci ([671f3c2](671f3c2))
* zero locked balance ([528b5bc](528b5bc))

### Features

* make our lives easier ([43fa4bd](43fa4bd))
* remove outdated messages ([c613724](c613724))
* update supported btc address formats ([0a8fd55](0a8fd55))
@kyranjamie kyranjamie merged commit 1133f93 into main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedger friedger friedger requested changes

@kyranjamie kyranjamie kyranjamie approved these changes

@fbwoolf fbwoolf Awaiting requested review from fbwoolf

Assignees

@kyranjamie kyranjamie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade @stacks/stacking to 6.5.0 Remove cooldown copy from desktop wallet
6 participants
@edu-stx @markmhendrickson @314159265359879 @friedger @kyranjamie @semantic-release-bot