Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert coordinators #58

Merged
merged 5 commits into from
Oct 25, 2019
Merged

Alert coordinators #58

merged 5 commits into from
Oct 25, 2019

Conversation

sevenseas-gists
Copy link
Contributor

@sevenseas-gists sevenseas-gists commented Oct 11, 2019 •
edited
Loading

closes #47

@codecov-io
Copy link

codecov-io commented Oct 11, 2019 •
edited
Loading

Codecov Report

Merging #58 into master will increase coverage by 1.14%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #58      +/-   ##
===========================================
+ Coverage      1.98%   3.12%   +1.14%     
- Complexity      225     231       +6     
===========================================
  Files            19      19              
  Lines          1413    1439      +26     
===========================================
+ Hits             28      45      +17     
- Misses         1385    1394       +9
Impacted Files Coverage Δ Complexity Δ
classes/evasys_inviter.php 0% <0%> (ø) 58 <2> (+2) ⬆️
invite.php 0% <0%> (ø) 0 <0> (ø) ⬇️
classes/course_evasys_courses_allocation.php 100% <100%> (+100%) 5 <4> (+4) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bac1a3...a499761. Read the comment docs.

Dagefoerde
Dagefoerde suggested changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@Dagefoerde Dagefoerde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #52 (review). Thanks for making the changes! :)

tobiasreischmann
tobiasreischmann suggested changes Oct 23, 2019
View reviewed changes
classes/course_evasys_courses_allocation.php Outdated Show resolved Hide resolved
lang/de/block_evasys_sync.php Outdated Show resolved Hide resolved
@tobiasreischmann tobiasreischmann self-requested a review October 24, 2019 15:44
@tobiasreischmann tobiasreischmann merged commit afa6a09 into learnweb:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasreischmann tobiasreischmann tobiasreischmann approved these changes

@Dagefoerde Dagefoerde Dagefoerde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alert Evaluationcoordinator when a Teacher starts an evaluation in automatic mode.
4 participants
@sevenseas-gists @codecov-io @Dagefoerde @tobiasreischmann