Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Activity" tab from learner view #12816

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Nov 11, 2024

Summary

This PR Remove "Activity" tab from learner view

The currently on develop

image

After the clean up .

on this PR

Screen.Recording.2024-11-11.at.10.08.25.mov

On figma

image

References

Closes #12733

Reviewer guidance

  • Confirm that Tabs are no longer in use and all related code is cleaned up.
  • Verify that ActivityList is no longer rendered on this page (but remains in kolibri-common).
  • For both lessons and quizzes, only the first 10 items are displayed initially.
  • When there are more than 10 items, a "view more" button appears.
  • On clicking "view more," an additional 10 items are displayed.
  • Ensure all spacing and layout match the Figma design
  • Confirm that there are no regressions affecting existing functionality.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Nov 11, 2024
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AllanOXDi! great work on the clean up. It's already looking good. I have left a few comments to look into. Thanks again!

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AllanOXDi. Changes look good to me! We have some conflicts but I think we should be good once they are resolved.

@radinamatic
Copy link
Member

@AllanOXDi There seem to be a conflict which prevented the build of the artifacts after the last change, could you check it out? 🙏🏽

@AllanOXDi
Copy link
Member Author

Fixed!

@radinamatic
Copy link
Member

  1. Confirm that Tabs are no longer in use and all related code is cleaned up. ✔️

  2. Verify that ActivityList is no longer rendered on this page (but remains in kolibri-common). - not sure if this can be confirmed in the UI only

  3. For both lessons and quizzes, only the first 10 items are displayed initially. ✔️

  4. When there are more than 10 items, a "view more" button appears. ✔️

  5. On clicking "view more," an additional 10 items are displayed. ✔️

  6. Ensure all spacing and layout match the Figma design ✔️

  7. Confirm that there are no regressions affecting existing functionality. ❗

    a) Export CSV button is not working, absolutely nothing happens when clicked.

    b) My learner did complete an exercise, but it's not recorded/displayed in the summary:

    2024-11-21_18-17-53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Activity" tab from learner view
3 participants