-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Activity" tab from learner view #12816
base: develop
Are you sure you want to change the base?
Remove "Activity" tab from learner view #12816
Conversation
Build Artifacts
|
kolibri/plugins/coach/assets/src/views/reports/ReportsLearnerReportPage.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/reports/ReportsLearnerReportPage.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/reports/ReportsLearnerReportPage.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/reports/ReportsLearnerReportPage.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/reports/ReportsLearnerReportPage.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/reports/ReportsLearnerReportPage.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/reports/ReportsLearnerReportPage.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/reports/ReportsLearnerReportPage.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AllanOXDi! great work on the clean up. It's already looking good. I have left a few comments to look into. Thanks again!
fc5ba5d
to
994e26b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AllanOXDi. Changes look good to me! We have some conflicts but I think we should be good once they are resolved.
@AllanOXDi There seem to be a conflict which prevented the build of the artifacts after the last change, could you check it out? 🙏🏽 |
994e26b
to
54f0f24
Compare
Fixed! |
Summary
This PR Remove "Activity" tab from learner view
The currently on develop
After the clean up .
on this PR
Screen.Recording.2024-11-11.at.10.08.25.mov
On figma
References
Closes #12733
Reviewer guidance
ActivityList
is no longer rendered on this page (but remains inkolibri-common)
.Testing checklist
PR process
Reviewer checklist
yarn
andpip
)