Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception in MPFuture.__del__() #555

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Fix exception in MPFuture.__del__() #555

merged 2 commits into from
Feb 14, 2023

Conversation

justheuristic
Copy link
Member

This PR addresses the bug reported in #552 - or, at least, it should, since we cannot reproduce the problem locally.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #555 (49e4569) into master (7d1bb7d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
+ Coverage   75.90%   75.98%   +0.07%     
==========================================
  Files          81       81              
  Lines        7995     7995              
==========================================
+ Hits         6069     6075       +6     
+ Misses       1926     1920       -6     
Impacted Files Coverage Δ
hivemind/utils/mpfuture.py 89.33% <100.00%> (ø)
hivemind/dht/protocol.py 93.15% <0.00%> (+0.45%) ⬆️
hivemind/moe/server/server.py 44.26% <0.00%> (+0.54%) ⬆️
hivemind/dht/routing.py 94.11% <0.00%> (+0.58%) ⬆️
hivemind/moe/server/connection_handler.py 47.91% <0.00%> (+1.04%) ⬆️
hivemind/moe/server/runtime.py 70.00% <0.00%> (+1.66%) ⬆️

@borzunov borzunov changed the title Fix minor MPFuture issues Fix error in MPFuture.__del__() Feb 14, 2023
@borzunov borzunov changed the title Fix error in MPFuture.__del__() Fix exception in MPFuture.__del__() Feb 14, 2023
@borzunov borzunov merged commit 8c98caa into master Feb 14, 2023
@borzunov borzunov deleted the fix-no-active branch February 14, 2023 14:12
mryab pushed a commit that referenced this pull request Feb 15, 2023
This PR addresses the bug reported in #552 - or, at least, it should, since we cannot reproduce the problem locally.

(cherry picked from commit 8c98caa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants