Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment key already defined #16

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

jlosito
Copy link
Contributor

@jlosito jlosito commented Nov 22, 2023

This might be a duplicate of other pull requests. I do see some pull requests changing code around this area.

Even though this gets around the issue with the duplicate environment key already being stated, the application still does not stay up and running, but simply exits.

$ docker-compose -p habquickstart up -d
[+] Building 0.0s (0/0)                                                                                                                                               docker:desktop-linux
[+] Running 4/4
 ✔ Network habquickstart_default            Created                                                                                                                                   0.0s
 ✔ Container habquickstart-web-1-1          Started                                                                                                                                   0.0s
 ✔ Container habquickstart-web-2-1          Started                                                                                                                                   0.0s
 ✔ Container habquickstart-load-balancer-1  Started                                                                                                                                   0.0s

Copy link

@mysteryegg mysteryegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are reasonable and fix the issue from my testing. Not sure if I'm authorized to approve, but I'll submit feedback against the Learn Chef courses that this commit unblocks the guided exercises.
Note that in older versions of docker-compose, duplicate keys would overwrite each other instead of throwing an error, see docker/compose#5267

@SteveDelFante SteveDelFante merged commit e43afeb into learn-chef:main Apr 26, 2024
2 checks passed
@jlosito jlosito deleted the bug/docker-compose branch April 26, 2024 15:54
@SteveDelFante
Copy link
Contributor

The merged fix seems to work now for the Learn Chef habitat tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants