Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create note #4

Merged
merged 7 commits into from
May 15, 2024
Merged

Create note #4

merged 7 commits into from
May 15, 2024

Conversation

Rlemus93
Copy link
Contributor

Submitting Pull Request

✅ Project Details

  • Contributor: Ryan
  • Contributor: Mark
  • Did you run your tests? yes
  • Did you run your linter? yes

https://www.notion.so/learnacademy/LEARN-Practicum-6ca49333f5154c96bc67c7b986dfcebe?p=20b943f8541c4f45a9a786e513322031&pm=s

📝 Description of Changes

Copy link
Contributor

@sjproctor sjproctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small thing

@@ -28,7 +28,8 @@ module.exports = {
gray: "#6c6868",
lightGray: "#c4c2c2",
error: "#ff0000",
neutral: "#E5E5E5"
neutral: "#E5E5E5",
red: "#ff0000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a color here with the same hex code. So you can reference the color error instead of red

@Rlemus93 Rlemus93 merged commit 01b7757 into main May 15, 2024
2 checks passed
@Rlemus93 Rlemus93 deleted the create-note branch May 15, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants