SKT-2: Added get and post request in cats controller #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmnepali
changed the title
|
@iampujan Could you add more info about each endpoint you have created in this PR? Also instead of loading the controller, services for cats, create a cats module and import it in the app module. We will use this cats module as example module and add more functionalities. |
bhuwantm
reviewed
Jun 13, 2022
| @@ -1,10 +1,12 @@ | |||
| import { Module } from '@nestjs/common'; | |||
| import { AppController } from './app.controller'; | |||
| import { AppService } from './app.service'; | |||
| import { CatsController } from './cats/cats.controller'; | |||
| import { CatService } from './cats/cats.service'; | |||
|
|
|||
| @Module({ | |||
| imports: [], | |||
There was a problem hiding this comment.
- separate out cats module, it allows us to group related items in a single module
- import the cats.module.ts here
- by doing this things related to cats are placed under cats folder and access to items in cats occurs through it
|
|
||
| @Module({ | ||
| imports: [], | ||
| controllers: [AppController], | ||
| providers: [AppService], | ||
| controllers: [AppController, CatsController], |
There was a problem hiding this comment.
- after the cats.module.ts is imported we can remove CatsController from here
| controllers: [AppController], | ||
| providers: [AppService], | ||
| controllers: [AppController, CatsController], | ||
| providers: [AppService, CatService], |
There was a problem hiding this comment.
- after the cats.module.ts is imported we can remove CatsService from here
| @@ -0,0 +1,5 @@ | |||
| export class CreateCatDto { | |||
There was a problem hiding this comment.
create a dto folder and place all dto created files in there
| @Injectable() | ||
| export class CatService { | ||
| findAll(): string { | ||
| return 'This is cat world!.'; |
There was a problem hiding this comment.
- create an interface folder and create interface for cat
- don't just return plain string
- create a list of demo data of cats having type as defined in interface
- return list of above demo data
| @Get(':id') | ||
| findOne(@Param() params): string { | ||
| console.log(params.id); | ||
| return `This action returns a #${params.id} cat`; |
There was a problem hiding this comment.
- use service function to get specific cat (see comments in service file)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implementation of GET and POST requests in cats controller/
Description:
GET Requests:
i. GET
/cats/profileii. GET
/cats/(used async)iii. GET
/cats/:Id(any number or id)POST requests:
i. POST
/cats/