Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-i18next instead of i18n #173

Closed
TimDaub opened this issue Jul 1, 2019 · 0 comments · Fixed by #241
Closed

Use react-i18next instead of i18n #173

TimDaub opened this issue Jul 1, 2019 · 0 comments · Fixed by #241
Assignees
Labels

Comments

@TimDaub
Copy link
Collaborator

TimDaub commented Jul 1, 2019

Scope

  • The burner-wallet currently uses i18next directly
  • There is however an npm module called react-i18next, that allows direct translation by defining components
  • This e.g. allows to translate a text with an <a /> tag. A problem we encountered here

Deliverables

  • Investigate react-i18next and see if it fits our use case
  • If it does, replace all occurrences of i18next with react-i18next in the burner-wallet

As an example:

<div>
  {i18n.t("hello_world")}
</div>

should be replaced with an appropriate react-i18next equivalent.

Notes

Please also take a look at #140.

Gains for the project

  • Better translation for the users of the burner-wallet
  • More efficient translation for developers

Roles

bounty gardener: @TimDaub / 10%
bounty worker: name / 75%
bounty reviewer: name / 15%

@TimDaub TimDaub changed the title Use react-i18nnext instead of i18n Use react-i18next instead of i18n Jul 1, 2019
@TimDaub TimDaub added this to the pDAI demo for funding proposal milestone Jul 1, 2019
@iamonuwa iamonuwa self-assigned this Jul 8, 2019
TimDaub added a commit that referenced this issue Aug 28, 2019
Fix Use react-i18next instead of i18n #173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants