[Merged by Bors] - feat: More sup_indep lemmas
#5196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
mathlib3-pair
|
LGTM, but there is a linter error. bors d+ |
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
eric-wieser
reviewed
Jun 19, 2023
Mathlib/Order/SupIndep.lean
Outdated
| ! Please do not edit these lines, except to modify the commit id | ||
| ! if you have ported upstream changes. | ||
| -/ | ||
| import Mathlib.Data.Finset.Pairwise | ||
| import Mathlib.Data.Finset.Powerset | ||
| import Mathlib.Data.Finset.Sigma |
There was a problem hiding this comment.
This is not the same import order as mathlib3
eric-wieser
approved these changes
Jun 19, 2023
eric-wieser
reviewed
Jun 19, 2023
Comment on lines
+176
to
+185
| /- | ||
| Porting note: simpNF linter returns | ||
|
|
||
| "Left-hand side does not simplify, when using the simp lemma on itself." | ||
|
|
||
| However, simp does indeed solve the following. leanprover/std4#71 is related. | ||
|
|
||
| example {α ι} [Lattice α] [OrderBot α] (s : Finset ι) (f : ι → α) : | ||
| (s.attach.SupIndep fun a => f a) ↔ s.SupIndep f := by simp | ||
| -/ |
There was a problem hiding this comment.
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jun 19, 2023
Match leanprover-community/mathlib3#11932 Co-authored-by: Jeremy Tan Jie Rui <[email protected]> Co-authored-by: Parcly Taxel <[email protected]> Co-authored-by: Eric Wieser <[email protected]>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
sup_indep lemmassup_indep lemmas
alexkeizer
pushed a commit
that referenced
this pull request
Jun 22, 2023
Match leanprover-community/mathlib3#11932 Co-authored-by: Jeremy Tan Jie Rui <[email protected]> Co-authored-by: Parcly Taxel <[email protected]> Co-authored-by: Eric Wieser <[email protected]>
kim-em
pushed a commit
that referenced
this pull request
Jun 23, 2023
Match leanprover-community/mathlib3#11932 Co-authored-by: Jeremy Tan Jie Rui <[email protected]> Co-authored-by: Parcly Taxel <[email protected]> Co-authored-by: Eric Wieser <[email protected]>
kim-em
pushed a commit
that referenced
this pull request
Jun 25, 2023
Match leanprover-community/mathlib3#11932 Co-authored-by: Jeremy Tan Jie Rui <[email protected]> Co-authored-by: Parcly Taxel <[email protected]> Co-authored-by: Eric Wieser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match leanprover-community/mathlib3#11932