Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CategoryTheory): StructuredArrow c (Comma.fst F G) is equivalent toComma (Under.forget c ⋙ F) G #19891

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

javra
Copy link
Collaborator

@javra javra commented Dec 11, 2024


Open in Gitpod

Copy link

PR summary c360858690

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ofCommaFstEquivalence
+ ofCommaFstEquivalenceFunctor
+ ofCommaFstEquivalenceInverse
+ ofCommaSndEquivalence
+ ofCommaSndEquivalenceFunctor
+ ofCommaSndEquivalenceInverse

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-category-theory Category theory label Dec 11, 2024
@javra javra requested a review from TwoFX December 11, 2024 13:22
Comment on lines +880 to +882
/-- There is a canonical equivalence between the costructured arrow category with codomain `c` on
the functor `Comma.fst F G : Comma F G ⥤ F` and the comma category over
`Over.forget c ⋙ F : Over c ⥤ T` and `G`. -/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/-- There is a canonical equivalence between the costructured arrow category with codomain `c` on
the functor `Comma.fst F G : Comma F G ⥤ F` and the comma category over
`Over.forget c ⋙ F : Over c ⥤ T` and `G`. -/
/-- There is a canonical equivalence between the structured arrow category with domain `c` on
the functor `Comma.fst F G : Comma F G ⥤ F` and the comma category over
`Under.forget c ⋙ F : Under c ⥤ T` and `G`. -/

@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants