Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename DivInvMonoid.Pow #19884

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

eric-wieser
Copy link
Member

This didn't match the naming convention at all.

Loogle tells me that ZPow is slightly more common than PowInt, though both are used.

This is an instance, so the name needs no deprecation


Open in Gitpod

This didn't match the naming convention at all.

Loogle tells me that `ZPow` is slightly more common than `PowInt`, though both are used.

This is an instance, so the name needs no deprecation
@eric-wieser eric-wieser added the easy < 20s of review time. See the lifecycle page for guidelines. label Dec 11, 2024
@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Dec 11, 2024
Copy link

github-actions bot commented Dec 11, 2024

PR summary e3ac7530ba

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ DivInvMonoid.toZPow
+ SubNegMonoid.toZSMul
- DivInvMonoid.Pow
- SubNegMonoid.SMulInt

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant