-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Rat): (q₁ + q₂).den ∣ q₁.den.lcm q₂.den
#19842
base: master
Are you sure you want to change the base?
Conversation
b9b0ee3
to
292cf5a
Compare
PR summary d58b085839Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some suggestions to match mathlib style more closely below
Please remove the awaiting-author label when you've addressed these comments |
Co-authored-by: Ruben Van de Velde <[email protected]>
9c9e2eb
to
6a44fba
Compare
Co-authored-by: Bhavik Mehta <[email protected]>
6a44fba
to
d58b085
Compare
add a useful theorem
Rat.add_den_dvd_lcm
that claims that the denominator of the addition of two rational numbers divides the LCM of the denominators of its terms. A stronger result thanRat.add_den_dvd
that is already present, which still remains useful in many cases.