Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Rat): (q₁ + q₂).den ∣ q₁.den.lcm q₂.den #19842

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jhanschoo
Copy link
Collaborator

@jhanschoo jhanschoo commented Dec 9, 2024

add a useful theorem Rat.add_den_dvd_lcm that claims that the denominator of the addition of two rational numbers divides the LCM of the denominators of its terms. A stronger result than Rat.add_den_dvd that is already present, which still remains useful in many cases.


Open in Gitpod

@github-actions github-actions bot added new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-data Data (lists, quotients, numbers, etc) labels Dec 9, 2024
@jhanschoo jhanschoo added the easy < 20s of review time. See the lifecycle page for guidelines. label Dec 9, 2024
@jhanschoo jhanschoo force-pushed the rat_add_den_dvd_lcm branch from b9b0ee3 to 292cf5a Compare December 9, 2024 17:33
Copy link

github-actions bot commented Dec 9, 2024

PR summary d58b085839

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ add_den_dvd_lcm

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some suggestions to match mathlib style more closely below

Mathlib/Data/Rat/Lemmas.lean Outdated Show resolved Hide resolved
Mathlib/Data/Rat/Lemmas.lean Outdated Show resolved Hide resolved
Mathlib/Data/Rat/Lemmas.lean Outdated Show resolved Hide resolved
Mathlib/Data/Rat/Lemmas.lean Outdated Show resolved Hide resolved
Mathlib/Data/Rat/Lemmas.lean Outdated Show resolved Hide resolved
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-author A reviewer has asked the author a question or requested changes and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Dec 9, 2024
@Ruben-VandeVelde
Copy link
Collaborator

Please remove the awaiting-author label when you've addressed these comments

jhanschoo and others added 2 commits December 10, 2024 10:54
@jhanschoo jhanschoo removed the awaiting-author A reviewer has asked the author a question or requested changes label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants