Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: renaming all Column to Col #19825

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - chore: renaming all Column to Col #19825

wants to merge 7 commits into from

Conversation

madvorak
Copy link
Collaborator

@madvorak madvorak commented Dec 9, 2024 •
edited by eric-wieser
Loading

  • Matrix.fromColumns becomes Matrix.fromCols
  • Matrix.toColumns becomes Matrix.toCols
  • Matrix.updateColumn becomes Matrix.updateCol

Moves:

  • *fromColumns* -> *fromCols*
  • *toColumns* -> *toCols*
  • *updateColumn* -> *updateCol*

Discussion:
https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Matrix.2EfromRows.20and.20Matrix.2EfromColumns

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

PR summary 35c77c83be

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Continuous.matrix_updateCol
+ IsTotallyUnimodular.fromCols_one
+ IsTotallyUnimodular.one_fromCols
+ conjTranspose_fromCols_eq_fromRows_conjTranspose
+ conjTranspose_fromRows_eq_fromCols_conjTranspose
+ det_updateCol_add
+ det_updateCol_add_self
+ det_updateCol_add_smul_self
+ det_updateCol_eq_zero
+ det_updateCol_smul
+ det_updateCol_smul_left
+ det_updateCol_sum
+ diagonal_updateCol_single
+ equiv_compl_fromCols_mul_fromRows_eq_one_comm
+ fromCols
+ fromCols_apply_inl
+ fromCols_apply_inr
+ fromCols_col0_isTotallyUnimodular_iff
+ fromCols_ext_iff
+ fromCols_fromRows_eq_fromBlocks
+ fromCols_inj
+ fromCols_mulVec_sum_elim
+ fromCols_mul_fromBlocks
+ fromCols_mul_fromRows
+ fromCols_mul_fromRows_eq_one_comm
+ fromCols_neg
+ fromCols_one_isTotallyUnimodular_iff
+ fromCols_toCols
+ fromCols_zero
+ fromRows_fromCols_eq_fromBlocks
+ fromRows_mul_fromCols
+ map_updateCol
+ mul_fromCols
+ one_fromCols_isTotallyUnimodular_iff
+ permanent_updateCol_smul
+ reindex_updateCol
+ submatrix_updateCol_equiv
+ submatrix_updateCol_succAbove
+ toCols₁
+ toCols₁_apply
+ toCols₁_fromCols
+ toCols₂
+ toCols₂_apply
+ toCols₂_fromCols
+ transpose_fromCols
+ updateCol
+ updateCol_apply
+ updateCol_conjTranspose
+ updateCol_eq_self
+ updateCol_ne
+ updateCol_reindex
+ updateCol_self
+ updateCol_submatrix_equiv
+ updateCol_subsingleton
+ updateCol_transpose
+ vecMul_fromCols
+-+- _
- IsTotallyUnimodular.fromColumns_one
- IsTotallyUnimodular.one_fromColumns

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@madvorak madvorak requested a review from eric-wieser December 9, 2024 11:23
@madvorak madvorak added the awaiting-author A reviewer has asked the author a question or requested changes label Dec 9, 2024
@madvorak madvorak added awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 9, 2024
@madvorak madvorak added the awaiting-author A reviewer has asked the author a question or requested changes label Dec 10, 2024
@madvorak madvorak added awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 10, 2024
kim-em
kim-em reviewed Dec 10, 2024
View reviewed changes
Mathlib/LinearAlgebra/Matrix/Determinant/Basic.lean Outdated
rw [← det_transpose, ← updateRow_transpose, transpose_smul, det_updateRow_smul_left]
simp [updateRow_transpose, det_transpose]

@[deprecated (since := "2024-11-03")] alias det_updateColumn_smul' := det_updateColumn_smul_left
@[deprecated (since := "2024-11-03")] alias det_updateColumn_smul' := det_updateCol_smul_left
@[deprecated (since := "2024-11-03")] alias det_updateColumn_smul_left := det_updateCol_smul_left
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dates in this file are incorrect.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing!

@kim-em
Copy link
Contributor

kim-em commented Dec 10, 2024

Please fix the dates, then merge.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 10, 2024

✌️ madvorak can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@madvorak
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Dec 11, 2024
@madvorak
chore: renaming all Column to Col (#19825)
afdb949 
* `Matrix.fromColumns` becomes `Matrix.fromCols`
* `Matrix.toColumns` becomes `Matrix.toCols`
* `Matrix.updateColumn` becomes `Matrix.updateCol`

Moves:
- `*fromColumns*` -> `*fromCols*`
- `*toColumns*` -> `*toCols*`
- `*updateColumn*` -> `*updateCol*`

Discussion:
https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Matrix.2EfromRows.20and.20Matrix.2EfromColumns
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 11, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: renaming all Column to Col [Merged by Bors] - chore: renaming all Column to Col Dec 11, 2024
@mathlib-bors mathlib-bors bot closed this Dec 11, 2024
@mathlib-bors mathlib-bors bot deleted the matrix-fromcols branch December 11, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em kim-em left review comments

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
delegated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@madvorak @kim-em @eric-wieser @leanprover-community-mathlib4-bot