-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - perf: speedup using Submodule.restrictScalars_mem
instead of relying on defeq
#19711
Conversation
alreadydone
commented
Dec 3, 2024
!bench |
PR summary 407b6bffc3Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
Here are the benchmark results for commit 407b6bf. Benchmark Metric Change
===========================================================
+ ~Mathlib.RingTheory.Ideal.Cotangent instructions -21.6%
+ ~Mathlib.RingTheory.Kaehler.Basic instructions -6.2% |
These two occurences were discovered because they timed out in another PR; maybe more are still hidden. Not sure who might know about more situations that could benefit from this. Maybe @erdOne? |
I feel like this defeq abuse(?) happen very often (and I'm definitely guilty of many of them) that I unfortunately cannot give you a list of where it occurs. |
This looks like a positive change, thanks! bors merge |
Pull request successfully merged into master. Build succeeded: |
Submodule.restrictScalars_mem
instead of relying on defeqSubmodule.restrictScalars_mem
instead of relying on defeq