Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Complex): reProdIm lemmas #19709

Closed
wants to merge 3 commits into from

Conversation

javierlcontreras
Copy link
Collaborator

From FLT

Co-authored-by: Yaël Dillies [email protected]


Open in Gitpod

@javierlcontreras javierlcontreras added t-analysis Analysis (normed *, calculus) FLT part of the ongoing formalization of Fermat's Last Theorem labels Dec 3, 2024
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

PR summary 1eb98d3a2f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.IsCompact.reProdIm
+ reProdIm
+ reProdIm_eq_empty
+ reProdIm_nonempty
+ «exists»
+ «forall»

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@loefflerd loefflerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very reasonable to me. I guess the old name Complex.Set.reProdIm was a mistake, the new name is definitely better. Thanks!

maintainer delegate

Mathlib/Data/Complex/Basic.lean Outdated Show resolved Hide resolved
Copy link

🚀 Pull request has been placed on the maintainer queue by loefflerd.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 13, 2024

✌️ javierlcontreras can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@YaelDillies
Copy link
Collaborator

YaelDillies commented Dec 18, 2024

I guess the old name Complex.Set.reProdIm was a mistake

I can tell you what happened here: It was originally called set.re_prod_im, for dot notation. Then at some point notation was added and dot notation became redundant. Then mathport dropped all _root_ in declaration names, meaning that our definition was accidentally named Complex.Set.reProdIm (but nobody minded because dot notation wasn't used). Given that dot notation isn't useful here anymore, I think Complex.reProdIm has become the best option.

@YaelDillies YaelDillies added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Dec 18, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 18, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 18, 2024
From FLT

Co-authored-by: Yaël Dillies <[email protected]>



Co-authored-by: Yaël Dillies <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 18, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Complex): reProdIm lemmas [Merged by Bors] - feat(Complex): reProdIm lemmas Dec 18, 2024
@mathlib-bors mathlib-bors bot closed this Dec 18, 2024
@mathlib-bors mathlib-bors bot deleted the re_prod_im_nonempty branch December 18, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. delegated FLT part of the ongoing formalization of Fermat's Last Theorem maintainer-merge new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants