-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a file tracking results from the 1000+ theorems project #19634
base: master
Are you sure you want to change the base?
Conversation
PR summary d61e514b58Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
The new file seems to be in a random order. Since this project doesn't have a fixed order (theorem 1, theorem 2, ...), I'd suggest sorting it either alphabetically by theorem name (whether by Unicode collation or code-point order) or numerically by Wikidata code. (The 1000-plus data includes MSC codes, and use of those would be reasonable to provide more structure in the list on our website rather than having a purely alphabetical list there, but I'm not sure if sorting by MSC code would make so much sense for this source file.) |
Good catch! You were right (the old file depended on file system order in some sense); I've added sorting by wikidata ID now. |
Some of the titles contain unicode-escapes, e.g. |
That's added by the yaml generation script. I'll see if there's an option to output unicode instead. |
Extracted from #19634.
Generate 1000.json during the build, and check its well-formedness. And document yaml_check.py slightly better.
3bdbf3c
to
d1f62d7
Compare
d1f62d7
to
623063d
Compare
Updated and rebased now. This is ready for review again. |
For cross-reference: 1000-plus/1000-plus.github.io#6 and 1000-plus/1000-plus.github.io#7. |
Add a new file
1000.yaml
, tracking the formalisation status of theoremsfrom the 1000+ theorems project. Make
check-yaml
handle this file also.Future PRs will
stacks
attribute, and generate this file from the tagging