This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(zmod/basic) #18953
base: master
Are you sure you want to change the base?
feat(zmod/basic) #18953
Changes from 5 commits
3c3cc79
b27f870
9ac7521
e594e84
3a3ee04
0d2f77d
0f52ac6
4a0e970
6281a66
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either have a lemma
is_unit _ → is_unit _
or a function(zmod b)ˣ → (zmod a)ˣ
(possibly we want both!), but not a mix of them like this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its true that
a ∣ b → (zmod b → zmod a)
? I think this follows trivially from that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a single line proof, yes. Shall I remove it? I possibly need it for future work but I can add it then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's true that
a ∣ b → (zmod b →+* zmod a)
. It wouldn't surprise me if mathlib already had a coercionzmod b -> zmod a
for arbitrary a and b :-/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like you're mixing two steps at once.
and in fact that shows you can actually get an iff: