This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 298
feat(ring_theory/integral_domain): generalize card_fiber_eq_of_mem_range
#17653
Open
urkud
wants to merge
23
commits into
master
Choose a base branch
from
YK-card-fiber-eq
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ange` * Generalize `card_fiber_eq_of_mem_range` to homomorphisms from a group to a monoid. * Rename it to `monoid_hom.card_fiber_eq_of_mem_range`, use `to_additive`.
urkud
added
awaiting-review
The author would like community review of the PR
t-algebra
Algebra (groups, rings, fields etc)
labels
Nov 20, 2022
4 tasks
alreadydone
reviewed
Nov 21, 2022
src/ring_theory/integral_domain.lean
Outdated
Comment on lines
136
to
138
@[to_additive] lemma monoid_hom.card_fiber_eq_of_mem_range {M} [monoid M] [decidable_eq M] | ||
(f : G →* M) {x y : M} (hx : x ∈ set.range f) (hy : y ∈ set.range f) : | ||
(univ.filter $ λ g, f g = x).card = (univ.filter $ λ g, f g = y).card := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably make an equivalence f⁻¹ {x} ≃
f.ker
given x ∈ set.range f
.
urkud
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Nov 23, 2022
…/mathlib into YK-range-lift
Co-authored-by: Anne Baanen <[email protected]>
github-actions
bot
added
the
modifies-synchronized-file
This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR.
label
Feb 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
awaiting-author
A reviewer has asked the author a question or requested changes
modifies-synchronized-file
This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR.
t-algebra
Algebra (groups, rings, fields etc)
too-late
This PR was ready too late for inclusion in mathlib3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
card_fiber_eq_of_mem_range
to homomorphisms from a group to a monoid.monoid_hom.card_fiber_eq_of_mem_range
, useto_additive
.