CID-3369: Validate permissions on each installation before scanning #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedlajmileanix
changed the title
LeanIX GitHub Agent Code Coverage
|
ahmed-ali-55
reviewed
Jan 6, 2025
Comment on lines
45
to
55
| if (missingPermissions.isNotEmpty() || missingEvents.isNotEmpty()) { | ||
| var message = "GitHub App is missing the following " | ||
| var message = "$type missing the following " | ||
| if (missingPermissions.isNotEmpty()) { | ||
| message = message.plus("permissions: $missingPermissions") | ||
| } | ||
| if (missingEvents.isNotEmpty()) { | ||
| if (missingPermissions.isNotEmpty()) { | ||
| message = message.plus(", and the following") | ||
| message = message.plus(", and the following ") | ||
| } | ||
| message = message.plus("events: $missingEvents") | ||
| } |
There was a problem hiding this comment.
Missing events are only being check if missingPermissions.isNotEmpty() || missingEvents.isNotEmpty().
Not sure if this is by design or a mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Changes made
Validate permissions on each installation before scanning
✨ Type of change
Please delete the options that are not relevant.
🧪 How Has This Been Tested?
🏎 Checklist: