Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Leaderboard By Slug #233

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Get Leaderboard By Slug #233

merged 5 commits into from
Sep 19, 2024

Conversation

zysim
Copy link
Collaborator

@zysim zysim commented Aug 18, 2024 •
edited
Loading

Closes #230

@zysim zysim self-assigned this Aug 18, 2024
@zysim zysim requested a review from a team as a code owner August 18, 2024 05:03
@TheTedder TheTedder mentioned this pull request Aug 29, 2024
Merged
@zysim zysim force-pushed the getLeaderboardBySlug branch from 6b17c40 to 5585f18 Compare September 7, 2024 13:52
@zysim zysim force-pushed the getLeaderboardBySlug branch from 6ff43dc to dfda9a8 Compare September 10, 2024 10:31
TheTedder
TheTedder requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@TheTedder TheTedder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it so that deleted leaderboards are not returned. Add a test case or two for this scenario.

@zysim zysim requested a review from TheTedder September 17, 2024 09:44
@zysim zysim merged commit 826bb2e into leaderboardsgg:main Sep 19, 2024
1 check passed
@zysim zysim deleted the getLeaderboardBySlug branch September 19, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheTedder TheTedder TheTedder approved these changes

Assignees

@zysim zysim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get Leaderboard by Slug Endpoint
2 participants
@zysim @TheTedder