Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swashbuckle annotations #203

Merged
merged 22 commits into from
Jul 1, 2024
Merged

Conversation

TheTedder
Copy link
Contributor

Closes #168

@TheTedder TheTedder requested a review from a team as a code owner November 7, 2023 22:39
@zysim
Copy link
Collaborator

zysim commented Nov 8, 2023

I honestly don't know if I prefer the look of this change. I feel bad that you've already put in the work on this, but things feel less readable, personally. On top of that, the attributes can't be folded away, which gets distracting.

@TheTedder TheTedder force-pushed the swashbuckle-annotations branch from 32d62eb to 4c2eb64 Compare June 24, 2024 16:03
@TheTedder
Copy link
Contributor Author

I honestly don't know if I prefer the look of this change. I feel bad that you've already put in the work on this, but things feel less readable, personally. On top of that, the attributes can't be folded away, which gets distracting.

I updated it just in case you change your mind. I think the openapi doc is actually more correct this way.

@zysim
Copy link
Collaborator

zysim commented Jun 30, 2024

Honestly; this is fine. I'll merge this. nvm there's conflicts. I'll deal with it in a couple hours, if you haven't done so yourself, already.

zysim
zysim previously approved these changes Jun 30, 2024
@TheTedder TheTedder force-pushed the swashbuckle-annotations branch from a0b7260 to 36f5a02 Compare July 1, 2024 02:11
@TheTedder TheTedder requested a review from zysim July 1, 2024 02:12
Copy link
Collaborator

@zysim zysim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me. I like that we don't need to needlessly-annotate injected services anymore, as well. I wish we could make the error response schema more accurate (e.g. they all show status: 0 instead of the correct error code), but it's whatever. You can always just test out the API itself in the Swagger doc, anyway.

@zysim zysim merged commit 275d5d1 into leaderboardsgg:main Jul 1, 2024
1 check passed
@TheTedder TheTedder deleted the swashbuckle-annotations branch October 1, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Swashbuckle.AspNetCore.Annotations
2 participants