Pin .NET SDK version (#151)

* force .NET SDK 7.0.105 because of dotnet format bug * uncomment EnforceCodeStyleInBuild in csproj not needed with .NET SDK 7.0.105 * fix launchSettings.json * README: fix instructions to run from CLI
leaderboardsgg · Jun 4, 2023 · 777ff4f · 777ff4f
1 parent c5b9fc4
commit 777ff4f
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 13 deletions.
diff --git a/.github/workflows/test-backend.yml b/.github/workflows/test-backend.yml
@@ -14,7 +14,7 @@ jobs:
         - name: Setup dotnet 7
           uses: actions/setup-dotnet@v1
           with:
-            dotnet-version: '7.0.x'
+            dotnet-version: '7.0.105' # required because of dotnet format bug
         - name: Restore NuGet packages
           run: dotnet restore
         - name: Restore tools

diff --git a/LeaderboardBackend.Test/LeaderboardBackend.Test.csproj b/LeaderboardBackend.Test/LeaderboardBackend.Test.csproj
@@ -4,8 +4,7 @@
     <TargetFramework>net7.0</TargetFramework>
     <Nullable>enable</Nullable>
     <IsPackable>false</IsPackable>
-    <!-- Commenting out due to dotnet format bug: https://github.com/dotnet/format/issues/1800 -->
-    <!-- <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild> -->
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/LeaderboardBackend/LeaderboardBackend.csproj b/LeaderboardBackend/LeaderboardBackend.csproj
@@ -4,8 +4,7 @@
     <TargetFramework>net7.0</TargetFramework>
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
-    <!-- Commenting out due to dotnet format bug: https://github.com/dotnet/format/issues/1800 -->
-    <!-- <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild> -->
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
   </PropertyGroup>
 
   <PropertyGroup>

diff --git a/LeaderboardBackend/Properties/launchSettings.json b/LeaderboardBackend/Properties/launchSettings.json
@@ -1,14 +1,14 @@
 {
   "profiles": {
-    "LeaderboardBackendCsPoc": {
+    "LeaderboardBackend": {
       "commandName": "Project",
       "launchBrowser": true,
       "launchUrl": "swagger",
       "environmentVariables": {
         "ASPNETCORE_ENVIRONMENT": "Development"
       },
       "dotnetRunMessages": true,
-      "applicationUrl": "https://localhost:7128;http://localhost:5240"
+      "applicationUrl": "https://localhost:8080;http://localhost:8000"
     },
     "IIS Express": {
       "commandName": "IISExpress",

diff --git a/README.md b/README.md
@@ -141,19 +141,18 @@ dotnet ef database update
 
 #### Run the App
 
-To run the application from the CLI, run the following command from the root of the project:
+To run the application from the CLI, run the following command from the root of the repository:
 
+```bash
+cd LeaderboardBackend
+dotnet run  # or `dotnet watch` to run with hot reload 
 ```
-dotnet run --project LeaderboardBackend --urls https://localhost:7128 // dotnet watch run ... for hotfixing
-```
-
-The value provided to `--urls` has to match what's listed under `applicationUrl` in `LeaderboardBackend/Properties/launchSettings.json`. As of this writing, it's `https://localhost:7128`.
 
 #### Test the App
 Docker is required to run integration tests against a real Postgres database.  
 However, if you would still like to run the tests with an in-memory database, you can set the following environment variable: `INTEGRATION_TESTS_DB_BACKEND=InMemory`.
 
-To run the tests, run the following commands from the root of the project:
+To run the tests, run the following commands from the root of the repository:
 
 ```bash
 cd LeaderboardBackend.Test

diff --git a/global.json b/global.json
@@ -0,0 +1,5 @@
+{
+  "sdk": {
+    "version": "7.0.105"
+  }
+}