Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bnb 807 display overview of incomplete validation blocks with navigation #54

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Andresdev02
Copy link
Collaborator

As a user of the validation tool,
I want to see an overview of all incomplete validation blocks at the top of the page,
so that I can quickly identify and navigate to errors within the document structure.

Acceptance Criteria:

Overview Display:

Given: The validation tool detects errors in one or more document blocks,

When: The page is loaded,

Then: An overview is displayed at the top of the page, listing all incomplete validation blocks.

Hierarchical Structure:

Given: Errors exist within nested document structures (e.g., "Zitting > Document > Agendapunt"),

When: The overview is displayed,

Then: The errors are presented in the corresponding hierarchy with clear labels and error descriptions (e.g., "Zitting > Document > Agendapunt: Missing title").

Navigation:

Given: A user clicks on an item in the overview,

When: The item corresponds to a specific document block,

Then: The page smoothly scrolls to the associated block using the auto-scroll functionality implemented in the previous ticket.

Error Filtering:

Given: Only incomplete or invalid document blocks exist,

When: The overview is generated,

Then: Only the blocks with errors are displayed in the overview (complete blocks are excluded).

Error Filtering:

Given: Only incomplete or invalid document blocks exist,

When: The overview is generated,

Then: Only the blocks with errors are displayed in the overview (complete blocks are excluded).

@Andresdev02 Andresdev02 self-assigned this Dec 19, 2024
@brechtvdv
Copy link
Collaborator

If I test following decision:
http://localhost:4200/validation-results?documentType=Notulen&url=https%3A%2F%2Flblod.zottegem.be%2FLBLODWeb%2FHome%2FOverzicht%2Fe3d9480acc0cf400e11ab7afe2bcea144038dd2ef71d77247d5159c7ce8efb1a%2FGetPublication%3Ffilename%3DNotulen_Gemeenteraad_15-04-2024.html#validationBlock-9-1-10

Zitting 1 > locatie :

brings me to Agendapunt 10

Can you check what's wrong here?

@brechtvdv
Copy link
Collaborator

When I test: Besluit 11 > motivering : Waarde niet gevonden
http://localhost:4200/validation-results?documentType=Notulen&url=https%3A%2F%2Flblod.zottegem.be%2FLBLODWeb%2FHome%2FOverzicht%2Fe3d9480acc0cf400e11ab7afe2bcea144038dd2ef71d77247d5159c7ce8efb1a%2FGetPublication%3Ffilename%3DNotulen_Gemeenteraad_15-04-2024.html#validationBlock-3-16-9

Then the decision (Besluit 11) is completely opened: other properties like Besluit > volgtUit > heeftAanwezige... are all shown.
This makes it very overwhelming for a user.
Can you limit that the other properties of the decision are opened only one level?

@Andresdev02
Copy link
Collaborator Author

@brechtvdv it's should be ok now. Let me know if you still see something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants