Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build #10

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fix the build #10

merged 1 commit into from
Apr 10, 2024

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Apr 8, 2024

This frontend hasn't been changed in a long while. Since there is no lock file, issues slipped in and the build no longer works. This does the basic amount of needed changes to get things running again.

  • switch to ember-rdfa-helpers v0.6.0, the git branch we linked (and no longer exists 😅 ) is included in that
  • update ember-cli-fastboot to v4. This fixes a build issue I ran into.
  • Install Webpack explicitly. This is a requirement of ember-auto-import v2, not sure how that worked before since it should have errored at build time as well 🤔.
  • Enable the lock file so we are less likely to run into this in the future

This frontend hasn't been changed in a long while. Since there is no lock file, issues slipped in and the build no longer works. This does the basic amount of needed changes to get things running again.

- switch to ember-rdfa-helpers v0.6.0, the git branch we linked is included in that
- update ember-cli-fastboot to v4. This fixes a build issue due to a transitive dep not being compatible with the version we were using.
- Install Webpack explicitly. This is a requirement of ember-auto-import v2.
- Enable the lock file so we are less likely to run into this in the future
Copy link

@Rahien Rahien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me! many thanks Sam!

@Windvis Windvis merged commit 0be4758 into master Apr 10, 2024
@Windvis Windvis deleted the fix-the-build branch April 10, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants