Owen/rekenhof #301
Draft
Owen/rekenhof #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a route, template and controller for /rekenhof. Includes unfinished functionality to fetch data from api and display in a table
-Adds playwright package to package.json and package-lock.json -configures playwright to use localhost:4200 as default url in playwright.config.js -adds e2e folder with e2e/rekenhof.spec.js containing end2end playwright tests for the /rekenhof route.
…file to _shame.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IMPORTANT NOTE: added @playwright/test dependency.
Added /rekenhof route, controller and handlebars template.
Fetches relevant data about mandatarissen from rekenhof-api based on the logged in bestuursorgaan and displays in a table.
Also supports inputting salary information and exporting to csv.
Also has a toggleable mode that only fetches data from mandatarissen that have at least 1 aangifteplichtig mandaat.
How to test
Also run the owen/rekenhof branch of the backend and then navigate to /rekenhof in the frontend after logging in as a bestuurseenheid.
or run 'npx playwright test --ui' in a command prompt in the root folder of the project.
Links to other PR's
lblod/app-lokaal-mandatenbeheer#187