Fix publish service to handle non-200 success status codes

[piemonkey]

Overview

When testing calls to prepublish service, I noticed that one of the calls was returning a 201 created status code, which was being interpreted as a failure. I changed this call and some others I found to use the Response.ok field instead of checking for 200. I also replaced the confusing JSON.stringify(error) call as an error always serialises as {}.

connected issues and PRs:

Found when creating lblod/notulen-prepublish-service#124

Setup

This was found when working with an in-progress prepublisher which returned a 201 in place of a 200 for a job status. So, to test, you can run app-gn with a local version of the prepublisher. Modify the /prepublish/job-result/:jobUuid route to return a 201 status on success.

How to test/reproduce

This was visible when creating a job on the endpoint /meeting-notes-previews, so when producing the publish preview for a notulen.

Challenges/uncertainties

N/A

Checks PR readiness

• UI: works on smaller screen sizes
• UI: feedback for any loading/error states
• Check cancel/go-back flows
• Check database state correct when deleting/updating (especially regarding relationships)
• changelog
• npm lint
• no new deprecations