Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy parts to the agendapoint #796

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lagartoverde
Copy link
Contributor

Overview

Add a way of copying the parts of an agendapoint direclty from the agendapoint and not from the meeting

connected issues and PRs:

GN-5321

Setup

None

How to test/reproduce

Go to an agendapoint, in the file options you should have a copy decision parts button that should lead you to a new page where you can copy the decision parts

Challenges/uncertainties

None

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@lagartoverde lagartoverde added the enhancement New feature or request label Dec 12, 2024
@lagartoverde lagartoverde self-assigned this Dec 12, 2024
Copy link
Contributor

@piemonkey piemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it doesn't make sense to duplicate this route (also template and controller, etc). To me it would make sense to have both sources use this new route instead of the old one. We'd then need to use a similar approach to when editing an agendapoint, where we use a query param to say which 'go back to' we display.

@abeforgit
Copy link
Member

abeforgit commented Dec 18, 2024

I feel like it doesn't make sense to duplicate this route (also template and controller, etc). To me it would make sense to have both sources use this new route instead of the old one. We'd then need to use a similar approach to when editing an agendapoint, where we use a query param to say which 'go back to' we display.

No I disagree. Duplicating the route is OK, and I think the query param shenanigans we do for the meeting are a bit clunky. However, that doesn't mean we have to duplicate the contents of the route
what this looks like it needs is to extract (most) of the copy page into a component, and then reference it in both routes

EDIT: was a bit too strongly worded, in thinking more about it I'm less sure of my opinion, but I still think the duplication is better

@abeforgit
Copy link
Member

ember routing fundamentally drives the logic of the app, it's (perhaps unfortunately) a bit more than just "this url will render this page"
I think the way they want you to think about routing is very "object oriented"
so two different ways of getting to the same page can have different routes imo, even if only to avoid the weird query param stuff

we have components to avoid duplication

Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo: keep the route, but avoid the duplication by extracting to a component (but don't move the data-loading logic out of the route, just pass it through instead of loading it in the component)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants