-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy parts to the agendapoint #796
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it doesn't make sense to duplicate this route (also template and controller, etc). To me it would make sense to have both sources use this new route instead of the old one. We'd then need to use a similar approach to when editing an agendapoint, where we use a query param to say which 'go back to' we display.
No I disagree. Duplicating the route is OK, and I think the query param shenanigans we do for the meeting are a bit clunky. However, that doesn't mean we have to duplicate the contents of the route EDIT: was a bit too strongly worded, in thinking more about it I'm less sure of my opinion, but I still think the duplication is better |
ember routing fundamentally drives the logic of the app, it's (perhaps unfortunately) a bit more than just "this url will render this page" we have components to avoid duplication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo: keep the route, but avoid the duplication by extracting to a component (but don't move the data-loading logic out of the route, just pass it through instead of loading it in the component)
Overview
Add a way of copying the parts of an agendapoint direclty from the agendapoint and not from the meeting
connected issues and PRs:
GN-5321
Setup
None
How to test/reproduce
Go to an agendapoint, in the file options you should have a copy decision parts button that should lead you to a new page where you can copy the decision parts
Challenges/uncertainties
None
Checks PR readiness