add form predicate to make a form field read-only #194
Conversation
|
Not sure what's up with CI. It seems to complain about this line: https://github.com/frogcat/ttl2jsonld/blob/686ae54dd13c5769750a0dd879c5551c8e1ca7ad/ttl2jsonld.js#L4617 But don't understand why that line is being executed during the build and why it only starts error'ing now 🤔 Edit: it seems to be related to the removal of ember-data-table from Appuniversum v3.7.0. ember-data-table still depends on ember-auto-import v1, which brings in Webpack v4. Once Webpack v4 is no longer in the dependency tree we see the Webpack 5 error about url not being available 🤔 but only under Embroider. |
| @tracked | ||
| rdflibDisplayShow = null; | ||
| get displayShow() { | ||
| return (this.rdflibDisplayShow && this.rdflibDisplayShow.value) === '1'; |
There was a problem hiding this comment.
I would use Literal.toJs (we use this in some places already) so you don't have to do this === '1' check.
| sh:order 223 ; | ||
| sh:path ext:inputValue ; | ||
| form:displayType displayTypes:defaultInput ; | ||
| form:displayShow true ; |
There was a problem hiding this comment.
Was the predicate name of this discussed with Felix? Just double checking since it's pretty final after we merge this 😄.
There was a problem hiding this comment.
No, see this is a draft "POC" PR ;)
As I indeed miss the needed context and history to make a correct decision on this.
add the usage of the predicate
form:displayshow(a boolean) to a form field to specify if@showshould be true or not (which is used to if it is read-only or not). Before, only a whole form could be set as read-only. Now this can be done per field.I couldn't find a way to support it without changing the templates, as the logic for
@showis mainly in there.