Add and Refactor theme components #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sudhanshu dasgupta <[email protected]>
sudhanshutech
commented
Jan 27, 2024
| root: ({ theme }) => { | ||
| const { | ||
| palette: { | ||
| secondary: { main } |
There was a problem hiding this comment.
@nebula-aac require your review here while defining secondary.
In paletteOptions interface primary was only defined , so do we required to define secondary there too? Or it will work?
There was a problem hiding this comment.
And defining like this will also take care for ui which have only light mode like cloud? @nebula-aac
…o add/refactor/comp Signed-off-by: sudhanshu dasgupta <[email protected]>
Signed-off-by: sudhanshu dasgupta <[email protected]>
Signed-off-by: sudhanshu dasgupta <[email protected]>
nebula-aac
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
Signed commits