-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sistent-divider-component #6048
Open
mdkaifansari04
wants to merge
9
commits into
layer5io:master
Choose a base branch
from
mdkaifansari04:feat/sistent-divider-component
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+948
−70
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b43e1fe
feat: add sistent-divider-component
mdkaifansari04 d20a044
fix: paragraph color on hover
mdkaifansari04 ec4fa5c
chore: removed initialTheme from code example
mdkaifansari04 c1efa8c
chore: fix component not used warning
mdkaifansari04 82201de
chore: refactor the code example indentation
mdkaifansari04 3fb31b9
Merge branch 'master' of https://github.com/layer5io/layer5 into feat…
mdkaifansari04 1b49a8f
chore: removed SistentThemeProvider from code example
mdkaifansari04 2e22f8b
feat: add props section
mdkaifansari04 089e64c
fix: typo
mdkaifansari04 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import React from "react"; | ||
import { DividerCode } from "../../../../../sections/Projects/Sistent/components/divider/code"; | ||
|
||
const DividerCodePage = () => { | ||
return <DividerCode />; | ||
}; | ||
|
||
export default DividerCodePage; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import React from "react"; | ||
import { DividerGuidance } from "../../../../../sections/Projects/Sistent/components/divider/guidance"; | ||
|
||
const DividerGuidancePage = () => { | ||
return <DividerGuidance />; | ||
}; | ||
|
||
export default DividerGuidancePage; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import React from "react"; | ||
import SistentDivider from "../../../../../sections/Projects/Sistent/components/divider/index"; | ||
|
||
const SistentDividerPage = () => { | ||
return <SistentDivider />; | ||
}; | ||
|
||
export default SistentDividerPage; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
318 changes: 318 additions & 0 deletions
318
src/sections/Projects/Sistent/components/divider/code.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,318 @@ | ||
import { useLocation } from "@reach/router"; | ||
import { navigate } from "gatsby"; | ||
import React from "react"; | ||
|
||
import { | ||
Box, | ||
Chip, | ||
Divider, | ||
List, | ||
ListItem, | ||
ListItemText, | ||
SistentThemeProvider, | ||
styled, | ||
} from "@layer5/sistent"; | ||
|
||
import TabButton from "../../../../../reusecore/Button"; | ||
import { useStyledDarkMode } from "../../../../../theme/app/useStyledDarkMode"; | ||
import { SistentLayout } from "../../sistent-layout"; | ||
|
||
import FormatBoldIcon from "@mui/icons-material/FormatBold"; | ||
import FormatItalicIcon from "@mui/icons-material/FormatItalic"; | ||
import FormatAlignRightIcon from "@mui/icons-material/FormatAlignRight"; | ||
import FormatAlignCenterIcon from "@mui/icons-material/FormatAlignCenter"; | ||
import FormatAlignLeftIcon from "@mui/icons-material/FormatAlignLeft"; | ||
|
||
import { CodeBlock } from "../button/code-block"; | ||
|
||
const style = { | ||
py: 0, | ||
width: "100%", | ||
maxWidth: 360, | ||
borderRadius: 2, | ||
border: "1px solid", | ||
borderColor: "divider", | ||
backgroundColor: "background.paper", | ||
}; | ||
|
||
const Root = styled("div")(({ theme }) => ({ | ||
width: "100%", | ||
...theme.typography.body2, | ||
color: theme.palette.text.secondary, | ||
"& > :not(style) ~ :not(style)": { | ||
marginTop: theme.spacing(2), | ||
}, | ||
})); | ||
|
||
const content = ( | ||
<p style={{ color: "white" }}> | ||
{"Lorem ipsum dolor sit amet, consectetur adipiscing elit."} | ||
</p> | ||
); | ||
|
||
const codes = [ | ||
` <SistentThemeProvider initialMode={isDark ? "dark" : "light"}> | ||
<List sx={style}> | ||
<ListItem> | ||
<ListItemText primary="Full width variant below" /> | ||
</ListItem> | ||
<Divider component="li" /> | ||
<ListItem> | ||
<ListItemText primary="Inset variant below" /> | ||
</ListItem> | ||
<Divider variant="inset" component="li" /> | ||
<ListItem> | ||
<ListItemText primary="Middle variant below" /> | ||
</ListItem> | ||
<Divider variant="middle" component="li" /> | ||
<ListItem> | ||
<ListItemText primary="List item" /> | ||
</ListItem> | ||
</List> | ||
</SistentThemeProvider>`, | ||
|
||
` <SistentThemeProvider initialMode={isDark ? "dark" : "light"}> | ||
<Box | ||
sx={{ | ||
display: "inline-flex", | ||
alignItems: "center", | ||
border: "1px solid", | ||
borderColor: "divider", | ||
borderRadius: 2, | ||
bgcolor: "background.paper", | ||
color: "text.secondary", | ||
"& svg": { | ||
m: 1, | ||
}, | ||
}} | ||
> | ||
<FormatBoldIcon /> | ||
<Divider orientation="vertical" variant="middle" flexItem /> | ||
<FormatItalicIcon /> | ||
</Box> | ||
</SistentThemeProvider> | ||
`, | ||
` | ||
<SistentThemeProvider initialMode={isDark ? "dark" : "light"}> | ||
<Box | ||
sx={{ | ||
display: "flex", | ||
alignItems: "center", | ||
border: "1px solid", | ||
borderColor: "divider", | ||
borderRadius: 1, | ||
bgcolor: "background.paper", | ||
color: "text.secondary", | ||
"& svg": { | ||
m: 1, | ||
}, | ||
}} | ||
> | ||
<FormatAlignLeftIcon /> | ||
<FormatAlignCenterIcon /> | ||
<FormatAlignRightIcon /> | ||
<Divider orientation="vertical" flexItem /> | ||
<FormatBoldIcon /> | ||
</Box> | ||
</SistentThemeProvider> | ||
`, | ||
` <SistentThemeProvider initialMode={isDark ? "dark" : "light"}> | ||
<Root> | ||
{content} | ||
<Divider>CENTER</Divider> | ||
{content} | ||
<Divider textAlign="left">LEFT</Divider> | ||
{content} | ||
<Divider textAlign="right">RIGHT</Divider> | ||
{content} | ||
<Divider> | ||
<Chip label="Chip" size="small" /> | ||
</Divider> | ||
{content} | ||
</Root> | ||
</SistentThemeProvider>`, | ||
]; | ||
|
||
export const DividerCode = () => { | ||
const location = useLocation(); | ||
const { isDark } = useStyledDarkMode(); | ||
|
||
return ( | ||
<SistentLayout title="Divider"> | ||
<div className="content"> | ||
<a id="Identity"> | ||
<h2>Divider</h2> | ||
</a> | ||
<div className="filterBtns"> | ||
<TabButton | ||
className={ | ||
location.pathname === "/projects/sistent/components/divider" | ||
? "active" | ||
: "" | ||
} | ||
onClick={() => navigate("/projects/sistent/components/divider")} | ||
title="Overview" | ||
/> | ||
<TabButton | ||
className={ | ||
location.pathname === | ||
"/projects/sistent/components/divider/guidance" | ||
? "active" | ||
: "" | ||
} | ||
onClick={() => | ||
navigate("/projects/sistent/components/divider/guidance") | ||
} | ||
title="Guidance" | ||
/> | ||
<TabButton | ||
className={ | ||
location.pathname === "/projects/sistent/components/divider/code" | ||
? "active" | ||
: "" | ||
} | ||
onClick={() => | ||
navigate("/projects/sistent/components/divider/code") | ||
} | ||
title="Code" | ||
/> | ||
</div> | ||
<div className="main-content"> | ||
<p> | ||
The Divider component adds a subtle line to separate content | ||
sections, supporting horizontal/vertical orientation and | ||
customizable alignment for text or icons. Ideal for enhancing layout | ||
clarity. | ||
</p> | ||
<a id="Variant"> | ||
<h2>Variant Example</h2> | ||
</a> | ||
<p> | ||
The Divider component supports three variants: fullWidth (default), | ||
inset, and middle. | ||
</p> | ||
<div className="showcase"> | ||
<div className="items"> | ||
<SistentThemeProvider initialMode={isDark ? "dark" : "light"}> | ||
<List sx={style}> | ||
<ListItem> | ||
<ListItemText primary="Full width variant below" /> | ||
</ListItem> | ||
<Divider component="li" /> | ||
<ListItem> | ||
<ListItemText primary="Inset variant below" /> | ||
</ListItem> | ||
<Divider variant="inset" component="li" /> | ||
<ListItem> | ||
<ListItemText primary="Middle variant below" /> | ||
</ListItem> | ||
<Divider variant="middle" component="li" /> | ||
<ListItem> | ||
<ListItemText primary="List item" /> | ||
</ListItem> | ||
</List> | ||
</SistentThemeProvider> | ||
</div> | ||
<CodeBlock name="variant-example" code={codes[0]} /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Curious if it would make this more readable if instead of using array position for codes we use some map w/ a meaningful id so that if someone has to change it they will get some context of what each element in the array is. |
||
</div> | ||
<a id="Flex item"> | ||
<h2>Flex Item Example</h2> | ||
</a> | ||
<p> | ||
The <code>flexItem</code> prop allows the Divider to function | ||
properly within a flex container, ensuring it aligns with other flex | ||
items seamlessly. | ||
</p> | ||
<div className="showcase"> | ||
<div className="items"> | ||
<SistentThemeProvider initialMode={isDark ? "dark" : "light"}> | ||
<Box | ||
sx={{ | ||
display: "inline-flex", | ||
alignItems: "center", | ||
border: "1px solid", | ||
borderColor: "divider", | ||
borderRadius: 2, | ||
bgcolor: "background.paper", | ||
color: "text.secondary", | ||
"& svg": { | ||
m: 1, | ||
}, | ||
}} | ||
> | ||
<FormatBoldIcon /> | ||
<Divider orientation="vertical" variant="middle" flexItem /> | ||
<FormatItalicIcon /> | ||
</Box> | ||
</SistentThemeProvider> | ||
</div> | ||
<CodeBlock name="flex-example" code={codes[1]} /> | ||
</div> | ||
<a id="Orientation"> | ||
<h2>Orientation Example</h2> | ||
<p> | ||
The Divider component supports two orientations: horizontal and | ||
vertical. Each orientation serves different layout needs and | ||
enhances the visual structure of your content. | ||
</p> | ||
</a> | ||
<div className="showcase"> | ||
<div className="items"> | ||
<SistentThemeProvider initialMode={isDark ? "dark" : "light"}> | ||
<Box | ||
sx={{ | ||
display: "flex", | ||
alignItems: "center", | ||
border: "1px solid", | ||
borderColor: "divider", | ||
borderRadius: 1, | ||
bgcolor: "background.paper", | ||
color: "text.secondary", | ||
"& svg": { | ||
m: 1, | ||
}, | ||
}} | ||
> | ||
<FormatAlignLeftIcon /> | ||
<FormatAlignCenterIcon /> | ||
<FormatAlignRightIcon /> | ||
<Divider orientation="vertical" flexItem /> | ||
<FormatBoldIcon /> | ||
</Box> | ||
</SistentThemeProvider> | ||
</div> | ||
<CodeBlock name="orientation-example" code={codes[2]} /> | ||
</div> | ||
<a id="With children"> | ||
<h2>With children Example</h2> | ||
<p> | ||
The Divider component supports two orientations: horizontal and | ||
vertical. Each orientation serves different layout needs and | ||
enhances the visual structure of your content. | ||
</p> | ||
</a> | ||
<div className="showcase"> | ||
<div className="items"> | ||
<SistentThemeProvider initialMode={isDark ? "dark" : "light"}> | ||
<Root> | ||
{content} | ||
<Divider>CENTER</Divider> | ||
{content} | ||
<Divider textAlign="left">LEFT</Divider> | ||
{content} | ||
<Divider textAlign="right">RIGHT</Divider> | ||
{content} | ||
<Divider> | ||
<Chip label="Chip" size="small" /> | ||
</Divider> | ||
{content} | ||
</Root> | ||
</SistentThemeProvider> | ||
</div> | ||
<CodeBlock name="With-Children-example" code={codes[3]} /> | ||
</div> | ||
</div> | ||
</div> | ||
</SistentLayout> | ||
); | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyway we can simplify this?