Skip to content

Commit

Permalink
Upgrade Xcode version and iPhone version in Github Actions (facebook#…
Browse files Browse the repository at this point in the history
…1420)

Summary:

Now `macos-latest` aliases to `macos-14`, where `xcode-13.4.1` is not
available. Upgrade it to 15.4. Also use iPhone 14 simulator instead of
11 due to error of "test must be run on concrete device".

Differential Revision: D58144748
  • Loading branch information
lavenzg authored and facebook-github-bot committed Jun 6, 2024
1 parent 88e1ec4 commit 3aab250
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ jobs:
macos:
runs-on: macos-latest
steps:
- uses: maxim-lobanov/setup-xcode@v1.6.0
- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: 13.4.1
xcode-version: 15.4
- uses: actions/[email protected]
with:
path: hermes
Expand Down Expand Up @@ -115,9 +115,9 @@ jobs:
HERMES_WS_DIR: "/tmp/hermes"
HOMEBREW_NO_AUTO_UPDATE: 1
steps:
- uses: maxim-lobanov/setup-xcode@v1.6.0
- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: 13.4.1
xcode-version: 15.4
- uses: actions/[email protected]
- name: Cache setup
uses: actions/[email protected]
Expand All @@ -142,9 +142,9 @@ jobs:
test-macos:
runs-on: macos-latest
steps:
- uses: maxim-lobanov/setup-xcode@v1.6.0
- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: 13.4.1
xcode-version: 15.4
- uses: actions/[email protected]
with:
path: hermes
Expand All @@ -163,9 +163,9 @@ jobs:
HERMES_WS_DIR: "/tmp/hermes"
HOMEBREW_NO_AUTO_UPDATE: 1
steps:
- uses: maxim-lobanov/setup-xcode@v1.6.0
- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: 13.4.1
xcode-version: 15.4
- uses: actions/[email protected]
- name: Cache setup
uses: actions/[email protected]
Expand Down Expand Up @@ -195,7 +195,7 @@ jobs:
xcodebuild test \
-workspace ApplePlatformsIntegrationTests.xcworkspace \
-configuration Debug \
-destination 'platform=iOS Simulator,name=iPhone 11' \
-destination 'platform=iOS Simulator,name=iPhone 14' \
-scheme ApplePlatformsIntegrationMobileTests
working-directory: test/ApplePlatformsIntegrationTestApp
package-apple-runtime:
Expand All @@ -208,9 +208,9 @@ jobs:
HERMES_WS_DIR: "/tmp/hermes"
HOMEBREW_NO_AUTO_UPDATE: 1
steps:
- uses: maxim-lobanov/setup-xcode@v1.6.0
- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: 13.4.1
xcode-version: 15.4
- uses: actions/[email protected]
- name: Cache setup
uses: actions/[email protected]
Expand Down Expand Up @@ -550,9 +550,9 @@ jobs:
test-macos-test262:
runs-on: macos-latest
steps:
- uses: maxim-lobanov/setup-xcode@v1.6.0
- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: 13.4.1
xcode-version: 15.4
- uses: actions/[email protected]
with:
path: hermes
Expand Down

0 comments on commit 3aab250

Please sign in to comment.