Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: effective policy cmd argument parsing #1826

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

omerlavanet
Copy link
Collaborator

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@omerlavanet omerlavanet requested a review from oren-lava December 8, 2024 13:40
@omerlavanet omerlavanet changed the title bug: fix effective policy cmd argument parsing fix: fix effective policy cmd argument parsing Dec 8, 2024
@omerlavanet omerlavanet changed the title fix: fix effective policy cmd argument parsing fix: effective policy cmd argument parsing Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

Test Results

2 347 tests  ±0   2 347 ✅ ±0   27m 16s ⏱️ -2s
  122 suites ±0       0 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit 5921f10. ± Comparison against base commit ce4332c.

♻️ This comment has been updated with latest results.

@omerlavanet omerlavanet merged commit 4631607 into main Dec 8, 2024
31 of 32 checks passed
@omerlavanet omerlavanet deleted the fix-effective-policy-cmd branch December 8, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants