chore: Solana Subscription APIs #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oren-lava
requested review from
shleikes,
omerlavanet,
Yaroms and
ranlavanet
shleikes
requested changes
Nov 28, 2024
cookbook/specs/solana.json
Outdated
| "api_name": "accountSubscribe" | ||
| }, | ||
| { | ||
| "function_template": "{\"jsonrpc\":\"2.0\",\"method\":\"accountUnsubscribe\",\"params\":[0],\"id\":1}", |
There was a problem hiding this comment.
Why is it constant 0? I think it should be %s.
Please test this, and the rest of the unsubscribe methods as well
There was a problem hiding this comment.
After testing, it should be %d. see here: b30d822
Yaroms
added a commit
that referenced
this pull request
Dec 2, 2024
* update solana spec * update READMEs * fix solana spec * remove subscription APIs * chore: Solana Subscription APIs (#1808) * add subscription APIs to solana spec * minor fix for multiple SUBSCRIBE tags * fix unsubscribe methods * change solana unsubscribe params from %s to %d --------- Co-authored-by: Elad Gildnur <[email protected]> Co-authored-by: Yaroms <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Added subscription APIs and modified the protocol code
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...