Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CNS-v4-specs #1753

Merged
merged 1 commit into from
Oct 20, 2024
Merged

feat: CNS-v4-specs #1753

merged 1 commit into from
Oct 20, 2024

Conversation

Yaroms
Copy link
Collaborator

@Yaroms Yaroms commented Oct 20, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

Test Results

2 230 tests  +125   2 230 ✅ +127   26m 12s ⏱️ + 1m 14s
  145 suites +  2       0 💤 ±  0 
    7 files   +  1       0 ❌  -   2 

Results for commit 83946eb. ± Comparison against base commit fd2dd41.

@Yaroms Yaroms requested a review from omerlavanet October 20, 2024 12:51
@Yaroms Yaroms marked this pull request as ready for review October 20, 2024 12:51
@omerlavanet omerlavanet merged commit 1962ab0 into main Oct 20, 2024
30 checks passed
@omerlavanet omerlavanet deleted the CNS-v4-specs branch October 20, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants