Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CNS-1009 - estimated rewards query by cu #1721

Merged
merged 85 commits into from
Oct 13, 2024

Conversation

oren-lava
Copy link
Collaborator

Description

Closes: #XXXX

Re-implemented the estimate-rewards query to present a more accurate rewards estimation, by CU usage.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Base automatically changed from CNS-single-provider to main October 10, 2024 13:47
Copy link
Collaborator

@omerlavanet omerlavanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing adding tracked cu in the estimation to the provider in case the delegator adds more stake

proto/lavanet/lava/subscription/query.proto Show resolved Hide resolved
x/dualstaking/types/delegate.go Show resolved Hide resolved
x/subscription/keeper/grpc_query_estimated_rewards.go Outdated Show resolved Hide resolved
x/subscription/keeper/grpc_query_estimated_rewards.go Outdated Show resolved Hide resolved
@oren-lava
Copy link
Collaborator Author

missing adding tracked cu in the estimation to the provider in case the delegator adds more stake

done. see 615cbd8

@oren-lava oren-lava requested a review from omerlavanet October 13, 2024 13:36
@omerlavanet omerlavanet merged commit a5e41e5 into main Oct 13, 2024
30 checks passed
@omerlavanet omerlavanet deleted the CNS-1009-estimated-rewards-by-cu branch October 13, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants