Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PRT - Result generic parser #1711

Merged
merged 23 commits into from
Oct 9, 2024
Merged

feat: PRT - Result generic parser #1711

merged 23 commits into from
Oct 9, 2024

Conversation

shleikes
Copy link
Collaborator

No description provided.

@shleikes shleikes self-assigned this Sep 24, 2024
@shleikes shleikes mentioned this pull request Sep 24, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Test Results

2 219 tests  +12   2 219 ✅ +12   25m 29s ⏱️ -12s
  145 suites ± 0       0 💤 ± 0 
    7 files   ± 0       0 ❌ ± 0 

Results for commit 95e832b. ± Comparison against base commit f195bde.

♻️ This comment has been updated with latest results.

ranlavanet
ranlavanet requested changes Sep 25, 2024
View reviewed changes
protocol/parser/parser.go Outdated Show resolved Hide resolved
@shleikes shleikes requested a review from ranlavanet September 26, 2024 08:24
ranlavanet
ranlavanet previously approved these changes Sep 26, 2024
View reviewed changes
omerlavanet
omerlavanet requested changes Oct 7, 2024
View reviewed changes
protocol/parser/parser.go Show resolved Hide resolved
protocol/parser/parser.go Outdated Show resolved Hide resolved
protocol/parser/parser.go Show resolved Hide resolved
protocol/parser/parser.go Outdated Show resolved Hide resolved
protocol/parser/parser.go Show resolved Hide resolved
protocol/parser/parser.go Show resolved Hide resolved
protocol/parser/parser.go Show resolved Hide resolved
protocol/parser/parser.go Outdated Show resolved Hide resolved
@shleikes shleikes requested a review from omerlavanet October 8, 2024 08:30
omerlavanet
omerlavanet reviewed Oct 8, 2024
View reviewed changes
protocol/parser/parser.go Show resolved Hide resolved
protocol/parser/parser.go Show resolved Hide resolved
protocol/parser/parser.go Show resolved Hide resolved
omerlavanet
omerlavanet requested changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@omerlavanet omerlavanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix me pls

@omerlavanet omerlavanet merged commit bf46091 into main Oct 9, 2024
31 checks passed
@omerlavanet omerlavanet deleted the PRT-result-generic-parser branch October 9, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerlavanet omerlavanet omerlavanet approved these changes

@ranlavanet ranlavanet Awaiting requested review from ranlavanet

Assignees

@shleikes shleikes

Labels
C:proto C:protocol C:x/spec size/XL Team:Consensus Team:Protocol Type: Proto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shleikes @omerlavanet @ranlavanet